Bugzilla – Attachment 51311 Details for
Bug 16412
Cache undef in L1 only
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16412: Cache undef in L1 only
PASSED-QA-Bug-16412-Cache-undef-in-L1-only.patch (text/plain), 1.35 KB, created by
Katrin Fischer
on 2016-05-08 14:35:15 UTC
(
hide
)
Description:
[PASSED QA] Bug 16412: Cache undef in L1 only
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-05-08 14:35:15 UTC
Size:
1.35 KB
patch
obsolete
>From fa288ab5a7303628e01046286c9e51aea7d6a912 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 2 May 2016 12:26:44 +0200 >Subject: [PATCH] [PASSED QA] Bug 16412: Cache undef in L1 only > >No need to cache undef in L2. >Prevent numerous warnings like: >Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 > >Test plan: >Run t/Cache.t >Run t/db_dependent/sysprefs.t > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended patch: remove trailing space char and replace 'you' with 'we' to >match existing wordings. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Cache.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/Koha/Cache.pm b/Koha/Cache.pm >index 6f10b00..6b41e3c 100644 >--- a/Koha/Cache.pm >+++ b/Koha/Cache.pm >@@ -271,10 +271,11 @@ sub set_in_cache { > # Deep copy if it's not a scalar and unsafe is not passed > $value = dclone( $value ) if ref($value) and not $unsafe; > >- # Set in L1 cache >+ # Set in L1 cache; exit if we are caching an undef > $L1_cache{ $key } = $value; >+ return if !defined $value; > >- # We consider an expiry of 0 to be inifinite >+ # We consider an expiry of 0 to be infinite > if ( $expiry ) { > return $set_sub > ? $set_sub->( $key, $value, $expiry ) >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16412
:
51086
|
51089
|
51090
|
51310
| 51311