From c98ba17a53e1aecfacc544126aee9896004c6664 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 9 May 2016 15:03:12 +0100 Subject: [PATCH] [PASSED QA] Bug 16476: Do not call CGI->param in list context, some more Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer --- Koha/Plugins/Base.pm | 2 +- opac/ilsdi.pl | 4 ++-- svc/members/search | 2 +- svc/virtualshelves/search | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Koha/Plugins/Base.pm b/Koha/Plugins/Base.pm index 55e1e7b..4aa8e94 100644 --- a/Koha/Plugins/Base.pm +++ b/Koha/Plugins/Base.pm @@ -117,7 +117,7 @@ sub get_template { $template->param( CLASS => $self->{'class'}, - METHOD => $self->{'cgi'}->param('method'), + METHOD => scalar $self->{'cgi'}->param('method'), PLUGIN_PATH => $self->get_plugin_http_path(), ); diff --git a/opac/ilsdi.pl b/opac/ilsdi.pl index 108acc3..8320495 100755 --- a/opac/ilsdi.pl +++ b/opac/ilsdi.pl @@ -128,7 +128,7 @@ unless ( $cgi->param('service') ) { } # If user requested a service description, then display it -if ( $cgi->param('service') eq "Describe" and any { $cgi->param('verb') eq $_ } @services ) { +if ( scalar $cgi->param('service') eq "Describe" and any { scalar $cgi->param('verb') eq $_ } @services ) { my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => "ilsdi.tt", query => $cgi, @@ -137,7 +137,7 @@ if ( $cgi->param('service') eq "Describe" and any { $cgi->param('verb') eq $_ } debug => 1, } ); - $template->param( $cgi->param('verb') => 1 ); + $template->param( scalar $cgi->param('verb') => 1 ); output_html_with_http_headers $cgi, $cookie, $template->output; exit 0; } diff --git a/svc/members/search b/svc/members/search index 1c2d644..2599519 100755 --- a/svc/members/search +++ b/svc/members/search @@ -31,7 +31,7 @@ my $input = new CGI; exit unless $input->param('template_path'); my ($template, $user, $cookie) = get_template_and_user({ - template_name => $input->param('template_path'), + template_name => scalar $input->param('template_path'), query => $input, type => "intranet", authnotrequired => 0, diff --git a/svc/virtualshelves/search b/svc/virtualshelves/search index 5e991fc..0c827c0 100755 --- a/svc/virtualshelves/search +++ b/svc/virtualshelves/search @@ -13,7 +13,7 @@ my $input = new CGI; exit unless $input->param('template_path'); my ($template, $user, $cookie) = get_template_and_user({ - template_name => $input->param('template_path'), + template_name => scalar $input->param('template_path'), query => $input, type => "intranet", authnotrequired => 0, -- 1.9.1