Bugzilla – Attachment 51509 Details for
Bug 16504
All borrower attribute values for a given code deleted if that attribute has branch limits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons
Bug-16504-follow-up-for-bug-15163-Do-not-remove-at.patch (text/plain), 1.40 KB, created by
Srdjan Jankovic
on 2016-05-16 06:08:53 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2016-05-16 06:08:53 UTC
Size:
1.40 KB
patch
obsolete
>From 98cdc746dac4cc255681d788d3137112bb8b658d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 May 2016 14:43:52 +0100 >Subject: [PATCH] Bug 16504: (follow-up for bug 15163) Do not remove attributes > of other patrons > >Simple patch for a silly error, this single line is going to fix a >critical bug. >If a patron attribute is limited to a library, all the values for that attributes >for every patrons will be deleted. > >Test plan: >Create a patron attribute limited to a library >Set the the attribute for a patron >Set the the attribute for another patron >=> Without this patch applied, the attribute's value for the first >patron is deleted >=> With this patch applied, the 2 values exist in the DB after the >second edition > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > C4/Members/Attributes.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm >index 1036e58..b269532 100644 >--- a/C4/Members/Attributes.pm >+++ b/C4/Members/Attributes.pm >@@ -254,7 +254,7 @@ sub DeleteBorrowerAttributes { > $query .= $branch_limit > ? q{ > LEFT JOIN borrower_attribute_types_branches ON bat_code = code >- WHERE b_branchcode = ? OR b_branchcode IS NULL >+ WHERE ( b_branchcode = ? OR b_branchcode IS NULL ) > AND borrowernumber = ? > } > : q{ >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16504
:
51469
|
51470
|
51508
|
51509
|
51923
|
51924
|
51925