Bugzilla – Attachment 51769 Details for
Bug 16531
Circ overdues report is showing an empty table if no overdues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no overdues
SIGNED-OFF-Bug-16531-Circ-overdue-report-is-showin.patch (text/plain), 2.31 KB, created by
Owen Leonard
on 2016-05-25 12:16:25 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no overdues
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-05-25 12:16:25 UTC
Size:
2.31 KB
patch
obsolete
>From 40b8a078663cabc21351e35fde39929692e4c919 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 17 May 2016 04:46:31 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 16531: Circ overdue report is showing an > empty table if no overdues >Content-Type: text/plain; charset="utf-8" > >EDIT: Comment 2 > >To test: >1) Ensure you have no items overdue >2) Go to Circ -> Circulation reports -> Overdues >3) Notice empty table, '0 items overdue' heading >4) Apply patch and refresh page >5) Notice empty table is no longer showing and page says "There are no overdues" >6) Apply a filter to search >7) Page now says "There are no overdues matching your search" with a link to reset filter. >8) Click Reset filter -> confirm any filters you applied are cleared. >9) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) >10) Refresh overdue report page >11) Confirm table now shows correctly with '1 items overdue' heading etc. > >Sponsored-by: Catalyst IT >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../intranet-tmpl/prog/en/modules/circ/overdue.tt | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index 4ebc7d2..8f4a6f7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -77,13 +77,7 @@ > <div id="yui-main"> > <div class="yui-b"> > >-[% IF ( noreport ) %] >- >-<h2>Overdue report</h2> >- >-<p>Please choose one or more filters to proceed.</p> >- >-[% ELSE %] >+[% IF ( overdueloop ) %] > > <h2>[% nnoverdue %] [% IF ( noverdue_is_plural ) %]Items[% ELSE %]Item[% END %] > overdue as of [% todaysdate %][% IF ( isfiltered ) %] <span style="font-size:70%;">(Filtered. <a href="/cgi-bin/koha/circ/overdue.pl">Reset filter</a>)</span>[% END %]</h2> >@@ -127,7 +121,16 @@ overdue as of [% todaysdate %][% IF ( isfiltered ) %] <span style="font-size:70% > </table> > > </div> >-[% END %] <!-- noreport --> >+ >+[% ELSE %] >+<h2>Overdue report</h2> >+[% IF ( isfiltered ) %] >+ <p>There are no overdues matching your search. <a href="/cgi-bin/koha/circ/overdue.pl">Reset filter</a></p> >+[% ELSE %] >+ <p>There are no overdues.</p> >+[% END %] >+ >+[% END %] <!-- overdueloop --> > > </div> > </div> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16531
:
51556
|
51557
|
51729
|
51769
|
53059
|
53322
|
53434