Bugzilla – Attachment 51869 Details for
Bug 16597
Reflected XSS in [opac-]shelves and [opac-]shareshelf
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16597: Fix XSS in opac-shelves.pl
Bug-16597-Fix-XSS-in-opac-shelvespl.patch (text/plain), 1.70 KB, created by
Marcel de Rooy
on 2016-05-27 10:14:40 UTC
(
hide
)
Description:
Bug 16597: Fix XSS in opac-shelves.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-05-27 10:14:40 UTC
Size:
1.70 KB
patch
obsolete
>From 4ffadce333d49d09b5afc790bf410f4c644dde98 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Thu, 26 May 2016 21:06:18 +1200 >Subject: [PATCH] Bug 16597: Fix XSS in opac-shelves.pl >Content-Type: text/plain; charset=utf-8 > >To test >1/ Hit /cgi-bin/koha/opac-shelves.pl?shelfnumber=5&category=1&op=edit_form&referer="><script>alert('XSS')</SCRIPT> >2/ Notice JS is executed >3/ Apply patch >4/ Notice it's fixed > >This bug reported by > >Alex Middleton at Dionach > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index ab704ab..4050672 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -549,7 +549,7 @@ > [% ELSE %] > <legend>Editing <em>[% shelf.shelfname |html %]</em></legend> > <input type="hidden" name="op" value="edit" /> >- <input type="hidden" name="referer" value="[% referer %]" /> >+ <input type="hidden" name="referer" value="[% referer | html %]" /> > <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber | html %]" /> > [% END %] > <input type="hidden" name="owner" id="owner" value="[% loggedinusernumber %]" /> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16597
:
51818
|
51819
|
51820
|
51858
|
51859
|
51860
| 51869 |
51870
|
51871