From ed6a6e214f65748260da0aa2a3ca96151067871f Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 30 May 2016 12:17:00 +1000 Subject: [PATCH] Bug 16575 - Irregular behaviour using window.print() followed by window.location.href= Use print.css for OPAC basket when printing instead of using navigation. Currently, when you click "Print" on the OPAC basket, it'll navigate to a new page and initiate window.print() followed by a window.location.href change again. Unfortunately, due to differences in IE, Chrome, and FF, it will either show the print options, navigate away without showing them, or refuse to navigate away after printing. By changing to using print.css, we don't navigate away from the basket in the first place, so we prevent this irregular behaviour. _TEST PLAN_ 1) Apply the patch 2) Create an OPAC basket by clicking "Add to cart" on multiple items 3) Using Chrome, IE, and Firefox (of any version), click the "Print" button 4) You should see the relevant print menu without the OPAC basket re-loading in any way. 5) After printing is complete, you should still be on the OPAC basket pop-up --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt index fa7e496..11702a9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt @@ -16,7 +16,7 @@

Your cart

[% UNLESS ( print_basket ) %] -
+
[% IF ( verbose ) %] Brief display [% ELSE %] @@ -26,12 +26,12 @@ Send [% END %] Download - Print + Print Empty and close Hide window
-
+
Select all Clear all | -- 2.1.4