Bugzilla – Attachment 52108 Details for
Bug 16674
remove two broken test from t/Ris.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16674: remove two tests from t/Ris.t
Bug-16674-remove-two-tests-from-tRist.patch (text/plain), 1.20 KB, created by
Galen Charlton
on 2016-06-07 02:07:11 UTC
(
hide
)
Description:
Bug 16674: remove two tests from t/Ris.t
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2016-06-07 02:07:11 UTC
Size:
1.20 KB
patch
obsolete
>From b74a3c6dfd3e8853c95e112f731ba53ecbfcbc9c Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmcharlt@gmail.com> >Date: Tue, 7 Jun 2016 01:31:13 +0000 >Subject: [PATCH] Bug 16674: remove two tests from t/Ris.t > >This patch removes two tests that were broken by the patch for >bug 16442, thus preventing packages from being build in master. > >Ordinarily, one would either fix the tests or >change the code that broke the tests... but as the tests in >question check the return value of routines that do not >actually advertise a return value, I've elected to simply >remove them. > >To test >------- >[1] Verify that t/Ris.t passes. > >Signed-off-by: Galen Charlton <gmcharlt@gmail.com> >--- > t/Ris.t | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/t/Ris.t b/t/Ris.t >index 0840e2c..519746d 100755 >--- a/t/Ris.t >+++ b/t/Ris.t >@@ -6,14 +6,10 @@ > use strict; > use warnings; > >-use Test::More tests => 4; >+use Test::More tests => 2; > > BEGIN { > use_ok('C4::Ris'); > } > > is(C4::Ris::print_typetag(),undef,'test printing typetag'); >- >-is(C4::Ris::print_title(),undef, 'test printing title when print_title is nil'); >- >-is(C4::Ris::print_stitle(),undef, 'test printing info from series title field when its nil'); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16674
:
52108
|
52198