Bugzilla – Attachment 52125 Details for
Bug 16675
fix breakage of t/Languages.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16675: fix breakage of t/Languages.t
Bug-16675-fix-breakage-of-tLanguagest.patch (text/plain), 1.64 KB, created by
Marcel de Rooy
on 2016-06-07 12:55:55 UTC
(
hide
)
Description:
Bug 16675: fix breakage of t/Languages.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-06-07 12:55:55 UTC
Size:
1.64 KB
patch
obsolete
>From 690655c7406b944f63c305974d4b1cadfee0cb2c Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmcharlt@gmail.com> >Date: Tue, 7 Jun 2016 01:42:59 +0000 >Subject: [PATCH] Bug 16675: fix breakage of t/Languages.t >Content-Type: text/plain; charset=utf-8 > >This patch fixes test breakage introduced by the patch for bug 16088, >which added caching of getlanguages(). Upon inspection, it looks like >the patch for 16088 does not introduce a regression on bug 10560, >so this patch adds a couple cache-clearings. > >To test >------- >[1] Verify that t/Languages.t passes. > >Signed-off-by: Galen Charlton <gmcharlt@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/Languages.t | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/t/Languages.t b/t/Languages.t >index 8fee200..edd2a5a 100644 >--- a/t/Languages.t >+++ b/t/Languages.t >@@ -21,6 +21,7 @@ use Modern::Perl; > use Test::More tests => 4; > use Test::MockModule; > use CGI qw ( -utf8 ); >+use Koha::Cache::Memory::Lite; > > BEGIN { > use_ok('C4::Languages'); >@@ -51,8 +52,10 @@ my $query = CGI->new(); > @languages = ('de-DE', 'fr-FR'); > is(C4::Languages::getlanguage($query), 'de-DE', 'default to first language specified in syspref (bug 10560)'); > >+Koha::Cache::Memory::Lite->get_instance()->clear_from_cache('getlanguage'); > @languages = (); > is(C4::Languages::getlanguage($query), 'en', 'default to English if no language specified in syspref (bug 10560)'); > >+Koha::Cache::Memory::Lite->get_instance()->clear_from_cache('getlanguage'); > $return_undef = 1; > is(C4::Languages::getlanguage($query), 'en', 'default to English if no database'); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16675
:
52109
|
52125
|
52128
|
52160