Bugzilla – Attachment 52130 Details for
Bug 16441
C4::Letters::getletter is not plack safe
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16441: Fix Letters.t
Bug-16441-Fix-Letterst.patch (text/plain), 1.93 KB, created by
Marcel de Rooy
on 2016-06-07 13:32:22 UTC
(
hide
)
Description:
Bug 16441: Fix Letters.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-06-07 13:32:22 UTC
Size:
1.93 KB
patch
obsolete
>From 2fe6f6047f211ce7065c6558898483ca2ce7b4dc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Jun 2016 11:48:46 +0100 >Subject: [PATCH] Bug 16441: Fix Letters.t >Content-Type: text/plain; charset=utf-8 > >These tests were wrong, but the package variable used to cache the >letters hid the problem. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Letters.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index ed5c972..c28f90f 100644 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -326,7 +326,7 @@ $prepared_letter = GetPreparedLetter(( > substitute => $substitute, > repeat => $repeat, > )); >-is( $prepared_letter->{content}, q|This one only contains the date: | . output_pref({ dt => $date, dateonly => 1 }) . q|.|, 'dateonly test 2' ); >+is( $prepared_letter->{content}, q|And also this one:| . output_pref({ dt => $date, dateonly => 1 }) . q|.|, 'dateonly test 2' ); > > $dbh->do(q{UPDATE letter SET content = 'And also this one:<<timestamp|dateonly >>.' WHERE code = 'test_date';}); > $prepared_letter = GetPreparedLetter(( >@@ -337,7 +337,7 @@ $prepared_letter = GetPreparedLetter(( > substitute => $substitute, > repeat => $repeat, > )); >-is( $prepared_letter->{content}, q|This one only contains the date: | . output_pref({ dt => $date, dateonly => 1 }) . q|.|, 'dateonly test 3' ); >+is( $prepared_letter->{content}, q|And also this one:| . output_pref({ dt => $date, dateonly => 1 }) . q|.|, 'dateonly test 3' ); > > $dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('claimacquisition','TESTACQCLAIM','Acquisition Claim','Item Not Received','<<aqbooksellers.name>>|<<aqcontacts.name>>|<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered)</order>');}); > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16441
:
51218
|
51703
|
52120
|
52130
|
52217
|
52218