From 04ba002d7b0b4e1b097295272d70e51c67be9b8c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 27 May 2016 13:48:10 +0200 Subject: [PATCH] Bug 16717: Remove hardcoded category from Holds.t MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy Test passes OK Signed-off-by: Marc Véron --- t/db_dependent/Holds.t | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index 7e490e3..b368481 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -34,11 +34,7 @@ my $dbh = C4::Context->dbh; my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode }; my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode }; -# This test assumes we have a category S. This statement helps. -$builder->build({ - source => 'Category', - value => { categorycode => 'S', category_type => 'S' }, -}); +my $category = $builder->build({ source => 'Category' })->{categorycode}; my $borrowers_count = 5; @@ -64,7 +60,7 @@ foreach (1..$borrowers_count) { my $borrowernumber = AddMember( firstname => 'my firstname', surname => 'my surname ' . $_, - categorycode => 'S', + categorycode => $category, branchcode => $branch_1, ); push @borrowernumbers, $borrowernumber; -- 1.7.10.4