Bugzilla – Attachment 52340 Details for
Bug 16724
Link from online help to manual broken (as of version 16.05)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16724 - Link from online help to manual broken (as of version 16.05)
Bug-16724---Link-from-online-help-to-manual-broken.patch (text/plain), 1.21 KB, created by
Mirko Tietgen
on 2016-06-13 17:40:03 UTC
(
hide
)
Description:
Bug 16724 - Link from online help to manual broken (as of version 16.05)
Filename:
MIME Type:
Creator:
Mirko Tietgen
Created:
2016-06-13 17:40:03 UTC
Size:
1.21 KB
patch
obsolete
>From a4237112dce7df4772c2fe1352bae6375f4b1a99 Mon Sep 17 00:00:00 2001 >From: Mirko Tietgen <mirko@abunchofthings.net> >Date: Mon, 13 Jun 2016 19:20:38 +0200 >Subject: [PATCH] Bug 16724 - Link from online help to manual broken (as of > version 16.05) > >To test: >- apply patch >- load some page in staff client, open help, check the link to the manual > for 16.05, it should include 16.05 > for master, it should include 16.05 > for versions < 16, it should still work as before > >This will work for xx.05 and xx.11 releases. If we will have xx.04 or >xx.06 at some point, it has to be adjusted. >--- > help.pl | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/help.pl b/help.pl >index b812208..6acfddd 100755 >--- a/help.pl >+++ b/help.pl >@@ -69,7 +69,13 @@ my $help_version = C4::Context->preference("Version"); > if ( $help_version =~ m|^(\d+)\.(\d{2}).*$| ) { > my $version = $1; > my $major = $2; >- if ( $major % 2 ) { $major-- }; >+ if ($version < 16) { >+ if ( $major % 2 ) { $major-- }; >+ } >+ else { >+ unless ($major % 2) { $major-- }; >+ $major = sprintf("%02d", $major) >+ } > $help_version = "$version.$major"; > } > $template->param( helpVersion => $help_version ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16724
:
52339
|
52340
|
52341
|
52539