Bugzilla – Attachment 52638 Details for
Bug 12178
Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12178: Tests for changes to claimed serial status
Bug-12178-Tests-for-changes-to-claimed-serial-stat.patch (text/plain), 4.19 KB, created by
Jonathan Druart
on 2016-06-21 11:34:00 UTC
(
hide
)
Description:
Bug 12178: Tests for changes to claimed serial status
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-06-21 11:34:00 UTC
Size:
4.19 KB
patch
obsolete
>From b7f4af4f8be0ab901b56ab7b25127e6412dff01e Mon Sep 17 00:00:00 2001 >From: Florent Mara <florent.mara@gmail.com> >Date: Tue, 24 May 2016 14:10:32 +1200 >Subject: [PATCH] Bug 12178: Tests for changes to claimed serial status > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended patch: Remove trailing spaces >--- > t/db_dependent/Serials.t | 47 ++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 46 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index a144ec9..c51ca5a 100755 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -15,7 +15,7 @@ use C4::Bookseller; > use C4::Biblio; > use C4::Budgets; > use Koha::DateUtils; >-use Test::More tests => 46; >+use Test::More tests => 48; > > BEGIN { > use_ok('C4::Serials'); >@@ -27,6 +27,10 @@ my $dbh = C4::Context->dbh; > $dbh->{AutoCommit} = 0; > $dbh->{RaiseError} = 1; > >+# This could/should be used for all untested methods >+my @methods = ('updateClaim'); >+can_ok('C4::Serials', @methods); >+ > my $booksellerid = C4::Bookseller::AddBookseller( > { > name => "my vendor", >@@ -181,6 +185,47 @@ is(C4::Serials::HasSubscriptionExpired(), undef, 'test if the subscriptions has > > is(C4::Serials::GetLateOrMissingIssues(), undef, 'test getting last or missing issues'); > >+subtest 'test_updateClaim' => sub { >+ plan tests => 11; >+ >+ # Given ... nothing much >+ # When ... Then ... >+ my $result_0 = C4::Serials::updateClaim(undef); >+ is($result_0, undef, 'Got the expected undef from update claim with nothin'); >+ >+ # Given ... 3 serial. 2 of them updated. >+ my $serialids_1 = [90980, 90981]; >+ my $claimdate_1 = '2001/01/13'; # arbitrary date some time in the past. >+ my $claim_count_1 = 5; >+ Koha::Serial->new( { serialid => $serialids_1->[0], serialseq => 'serialseq', subscriptionid => $subscriptionid, status => 3, >+ biblionumber => 12345, claimdate => $claimdate_1, claims_count => $claim_count_1, } )->store(); >+ Koha::Serial->new( { serialid => $serialids_1->[1], serialseq => 'serialseq', subscriptionid => $subscriptionid, status => 3, >+ biblionumber => 12345, claimdate => $claimdate_1, claims_count => $claim_count_1, } )->store(); >+ Koha::Serial->new( { serialid => 90982, serialseq => 'serialseq', subscriptionid => $subscriptionid, status => 3, >+ biblionumber => 12345, claimdate => $claimdate_1, claims_count => $claim_count_1, } )->store(); >+ >+ # When ... >+ my $result_1 = C4::Serials::updateClaim($serialids_1); >+ >+ # Then ... >+ is($result_1, 2, 'Got the expected 2 from update claim with 2 serial ids'); >+ >+ my @late_or_missing_issues_1_0 = C4::Serials::GetLateOrMissingIssues(undef, $serialids_1->[0]); >+ isnt($late_or_missing_issues_1_0[0]->{claimdate}, $claimdate_1, 'Got the expected first different claim date from update claim'); >+ is($late_or_missing_issues_1_0[0]->{claims_count}, $claim_count_1+1, 'Got the expected first claim count from update claim'); >+ is($late_or_missing_issues_1_0[0]->{status}, 7, 'Got the expected first claim status from update claim'); >+ >+ my @late_or_missing_issues_1_1 = C4::Serials::GetLateOrMissingIssues(undef, $serialids_1->[1]); >+ isnt($late_or_missing_issues_1_1[0]->{claimdate}, $claimdate_1, 'Got the expected second different claim date from update claim'); >+ is($late_or_missing_issues_1_1[0]->{claims_count}, $claim_count_1+1, 'Got the expected second claim count from update claim'); >+ is($late_or_missing_issues_1_1[0]->{status}, 7, 'Got the expected second claim status from update claim'); >+ >+ my @late_or_missing_issues_1_2 = C4::Serials::GetLateOrMissingIssues(undef, 90982); >+ is($late_or_missing_issues_1_2[0]->{claimdate}, '13/01/2001', 'Got the expected unchanged claim date from update claim'); >+ is($late_or_missing_issues_1_2[0]->{claims_count}, $claim_count_1, 'Got the expected unchanged claim count from update claim'); >+ is($late_or_missing_issues_1_2[0]->{status}, 3, 'Got the expected unchanged claim status from update claim'); >+}; >+ > is(C4::Serials::getsupplierbyserialid(),undef, 'test getting supplier idea'); > > is(C4::Serials::check_routing(), undef, 'test checking route'); >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12178
:
38607
|
45983
|
49559
|
51732
|
52637
|
52638
|
52639
|
52801
|
52802
|
52803