Bugzilla – Attachment 52679 Details for
Bug 16798
automatic_renewals.pl should run before overdues and fines are generated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16798 - automatic_renewals.pl should run before overdues and fines are generated
Bug-16798---automaticrenewalspl-should-run-before-.patch (text/plain), 2.03 KB, created by
Kyle M Hall (khall)
on 2016-06-22 11:31:43 UTC
(
hide
)
Description:
Bug 16798 - automatic_renewals.pl should run before overdues and fines are generated
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-06-22 11:31:43 UTC
Size:
2.03 KB
patch
obsolete
>From 958834cc2e3d913bb74e6efe957ab94d90cbf891 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 22 Jun 2016 11:29:16 +0000 >Subject: [PATCH] Bug 16798 - automatic_renewals.pl should run before overdues > and fines are generated > >Unless an auto_renew item's circ rule has a "no renewal before" line >set, it will only auto-renew at the point where the item is technically >overdue. However, automatic_renewal.pl in etc/cron.daily/koha-common is >set to run *after* all those cronjobs! > >Test Plan: >1) On a package installation, set up an item to auto_renew with no > "no renewal before" rule. >2) On the morning it is autorenewed it should also have a fine >3) Change the cronjob order to that of this patch >4) Repeat step 1 >5) On the morning it is autorenewed it should not have a fine >--- > debian/koha-common.cron.daily | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/debian/koha-common.cron.daily b/debian/koha-common.cron.daily >index cbd7eed..4f4d146 100644 >--- a/debian/koha-common.cron.daily >+++ b/debian/koha-common.cron.daily >@@ -15,6 +15,7 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see <http://www.gnu.org/licenses/>. > >+koha-foreach --enabled /usr/share/koha/bin/cronjobs/automatic_renewals.pl > koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/overdue_notices.pl -t > koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl > koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/advance_notices.pl -c >@@ -24,5 +25,4 @@ koha-foreach --enabled /usr/share/koha/bin/cronjobs/services_throttle.pl > /dev/ > koha-foreach --enabled /usr/share/koha/bin/cronjobs/cleanup_database.pl --sessions --zebraqueue 10 --list-invites > koha-foreach --enabled --noemail /usr/share/koha/bin/cronjobs/cleanup_database.pl --mail > koha-foreach --enabled /usr/share/koha/bin/cronjobs/holds/auto_unsuspend_holds.pl > /dev/null 2>&1 >-koha-foreach --enabled /usr/share/koha/bin/cronjobs/automatic_renewals.pl > koha-run-backups --days 2 --output /var/spool/koha >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16798
: 52679