From 19b9c882b8f12cd16a1f97e9b177e5cc64dd377e Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 1 Mar 2016 14:49:20 +0000 Subject: [PATCH] Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey --- Koha/Borrower/Modification.pm | 2 +- Koha/Checkout.pm | 2 +- Koha/Checkouts.pm | 2 +- Koha/News.pm | 2 +- Koha/NewsItem.pm | 2 +- Koha/Patron/Modifications.pm | 2 +- Koha/Suggestion.pm | 2 +- Koha/Suggestions.pm | 2 +- tools/letter.pl | 1 + 9 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Koha/Borrower/Modification.pm b/Koha/Borrower/Modification.pm index ceb9df2..35f56f4 100644 --- a/Koha/Borrower/Modification.pm +++ b/Koha/Borrower/Modification.pm @@ -39,7 +39,7 @@ Koha::Item - Koha Item object class =cut -sub type { +sub _type { return 'BorrowerModification'; } diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm index 5085cf2..358f41c 100644 --- a/Koha/Checkout.pm +++ b/Koha/Checkout.pm @@ -39,7 +39,7 @@ Koha::Checkout - Koha Checkout object class =cut -sub type { +sub _type { return 'Issue'; } diff --git a/Koha/Checkouts.pm b/Koha/Checkouts.pm index b2781c6..374cfb1 100644 --- a/Koha/Checkouts.pm +++ b/Koha/Checkouts.pm @@ -41,7 +41,7 @@ Koha::Checkouts - Koha Checkout object set class =cut -sub type { +sub _type { return 'Issue'; } diff --git a/Koha/News.pm b/Koha/News.pm index f57d07b..4a3d759 100644 --- a/Koha/News.pm +++ b/Koha/News.pm @@ -41,7 +41,7 @@ Koha::News - Koha News object set class =cut -sub type { +sub _type { return 'OpacNews'; } diff --git a/Koha/NewsItem.pm b/Koha/NewsItem.pm index c7d9efc..9d0dd63 100644 --- a/Koha/NewsItem.pm +++ b/Koha/NewsItem.pm @@ -41,7 +41,7 @@ Koha::NewsItem represents a single piece of news from the opac_news table =cut -sub type { +sub _type { return 'OpacNews'; } diff --git a/Koha/Patron/Modifications.pm b/Koha/Patron/Modifications.pm index 441dc55..cd886a1 100644 --- a/Koha/Patron/Modifications.pm +++ b/Koha/Patron/Modifications.pm @@ -312,7 +312,7 @@ sub GetModifications { return $data; } -sub type { +sub _type { return 'BorrowerModification'; } diff --git a/Koha/Suggestion.pm b/Koha/Suggestion.pm index da7f3d4..a091f43 100644 --- a/Koha/Suggestion.pm +++ b/Koha/Suggestion.pm @@ -39,7 +39,7 @@ Koha::Suggestion - Koha Suggestion object class =cut -sub type { +sub _type { return 'Suggestion'; } diff --git a/Koha/Suggestions.pm b/Koha/Suggestions.pm index 4202bab..73ad28d 100644 --- a/Koha/Suggestions.pm +++ b/Koha/Suggestions.pm @@ -41,7 +41,7 @@ Koha::Suggestions - Koha Suggestion object set class =cut -sub type { +sub _type { return 'Suggestion'; } diff --git a/tools/letter.pl b/tools/letter.pl index 9f8ac95..35c8997 100755 --- a/tools/letter.pl +++ b/tools/letter.pl @@ -259,6 +259,7 @@ sub add_validate { my @content = $input->multi_param('content'); for my $mtt ( @mtt ) { my $is_html = $input->param("is_html_$mtt"); + my $is_tt = $input->param("is_tt_$mtt") ? 1 : 0; my $title = shift @title; my $content = shift @content; my $letter = C4::Letters::getletter( $oldmodule, $code, $branchcode, $mtt); -- 2.1.4