From 71d546d3733bd063310684a5d4d729014f063680 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 24 Jun 2016 17:02:59 +0100 Subject: [PATCH] Bug 16805: Add test to getalert (no param passed) TEST PLAN --------- 1) apply patch 2) prove t/db_dependent/Letters.t -- fails 3) run koha qa test tools Signed-off-by: Mark Tompsett --- t/db_dependent/Letters.t | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t index a78dcde..a4ddd2a 100644 --- a/t/db_dependent/Letters.t +++ b/t/db_dependent/Letters.t @@ -18,7 +18,7 @@ # along with Koha; if not, see . use Modern::Perl; -use Test::More tests => 73; +use Test::More tests => 74; use Test::MockModule; use Test::Warn; @@ -210,14 +210,16 @@ my $externalid = 'my external id'; my $alert_id = C4::Letters::addalert($borrowernumber, $type, $externalid); isnt( $alert_id, undef, 'addalert does not return undef' ); -my $alerts = C4::Letters::getalert($borrowernumber); + +# getalert +my $alerts = C4::Letters::getalert(); +is( @$alerts, 1, 'addalert should not fail without parameter' ); +$alerts = C4::Letters::getalert($borrowernumber); is( @$alerts, 1, 'addalert adds an alert' ); is( $alerts->[0]->{alertid}, $alert_id, 'addalert returns the alert id correctly' ); is( $alerts->[0]->{type}, $type, 'addalert stores the type correctly' ); is( $alerts->[0]->{externalid}, $externalid, 'addalert stores the externalid correctly' ); - -# getalert $alerts = C4::Letters::getalert($borrowernumber, $type); is( @$alerts, 1, 'getalert returns the correct number of alerts' ); $alerts = C4::Letters::getalert($borrowernumber, $type, $externalid); -- 2.1.4