From c532a3c33a38357062e50f0014bd05885d8ba5fb Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Fri, 24 Jun 2016 12:28:27 -0400 Subject: [PATCH] Bug 16805: Tweak new test message to say getalert It said 'addalert', which is likely a cut-paste typo. Plus, let's keep running the other tests if that one goes bad. TEST PLAN --------- 1) Apply Jonathan's test patch 2) prove t/db_dependent/Letters.t -- dies before finishing tests 3) Apply this test patch 4) prove t/db_dependent/Letters.t -- says 'getalert' -- fails on one test, but keeps going. 5) run koha qa test tools. Signed-off-by: Mark Tompsett --- t/db_dependent/Letters.t | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t index a4ddd2a..c043db1 100644 --- a/t/db_dependent/Letters.t +++ b/t/db_dependent/Letters.t @@ -212,8 +212,11 @@ isnt( $alert_id, undef, 'addalert does not return undef' ); # getalert -my $alerts = C4::Letters::getalert(); -is( @$alerts, 1, 'addalert should not fail without parameter' ); +my $alerts; +eval { + $alerts = C4::Letters::getalert(); + is( @$alerts, 1, 'getalert should not fail without parameter' ); +} || fail('getalert failed horribly without a parameter'); $alerts = C4::Letters::getalert($borrowernumber); is( @$alerts, 1, 'addalert adds an alert' ); is( $alerts->[0]->{alertid}, $alert_id, 'addalert returns the alert id correctly' ); -- 2.1.4