Bugzilla – Attachment 52881 Details for
Bug 16805
Log in with database admin user breaks OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16805: Tweak new test message to say getalert
Bug-16805-Tweak-new-test-message-to-say-getalert.patch (text/plain), 1.42 KB, created by
Jonathan Druart
on 2016-06-26 07:08:44 UTC
(
hide
)
Description:
Bug 16805: Tweak new test message to say getalert
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-06-26 07:08:44 UTC
Size:
1.42 KB
patch
obsolete
>From dcde831c27aa82490e24636ed005fe1f2dcd1018 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 24 Jun 2016 12:28:27 -0400 >Subject: [PATCH] Bug 16805: Tweak new test message to say getalert > >It said 'addalert', which is likely a cut-paste typo. >Plus, let's keep running the other tests if that one >goes bad. > >TEST PLAN >--------- >1) Apply Jonathan's test patch >2) prove t/db_dependent/Letters.t > -- dies before finishing tests >3) Apply this test patch >4) prove t/db_dependent/Letters.t > -- still dies before finished tests, > 'addalert' now is 'getalert' in message. >5) run koha qa test tools. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Letters.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index a4ddd2a..39d11c7 100644 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -213,7 +213,7 @@ isnt( $alert_id, undef, 'addalert does not return undef' ); > > # getalert > my $alerts = C4::Letters::getalert(); >-is( @$alerts, 1, 'addalert should not fail without parameter' ); >+is( @$alerts, 1, 'getalert should not fail without parameter' ); > $alerts = C4::Letters::getalert($borrowernumber); > is( @$alerts, 1, 'addalert adds an alert' ); > is( $alerts->[0]->{alertid}, $alert_id, 'addalert returns the alert id correctly' ); >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16805
:
52762
|
52764
|
52827
|
52845
|
52846
|
52847
|
52877
|
52878
|
52879
|
52880
| 52881 |
52882