From 0ced3ae0c72426ba8c7355899ecb0a52c9a8410f Mon Sep 17 00:00:00 2001 From: Hector Castro Date: Fri, 24 Jun 2016 15:55:40 -0600 Subject: [PATCH] Bug 16812: Remove multiple onclick events for all z3950_search.tt z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt This patch propose: -Trigger event via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test to "Import" and close the dialog "X". Use the "Import" from table too. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. DataTable it is specific for each template Sponsored-by: Universidad de El Salvador --- .../prog/en/includes/z3950_search.inc | 21 ++++++ .../prog/en/modules/acqui/z3950_search.tt | 53 +++------------ .../en/modules/cataloguing/z3950_auth_search.tt | 68 ++++---------------- .../prog/en/modules/cataloguing/z3950_search.tt | 67 ++++--------------- koha-tmpl/intranet-tmpl/prog/js/z3950_search.js | 75 ++++++++++++++++++++++ 5 files changed, 131 insertions(+), 153 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/z3950_search.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/js/z3950_search.js diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/z3950_search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/z3950_search.inc new file mode 100644 index 0000000..88a933c --- /dev/null +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/z3950_search.inc @@ -0,0 +1,21 @@ +[% IF ( total_pages ) %] + +[% END %] + diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt index ebb18df..5c597f7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ -17,25 +17,6 @@ "aaSorting": [[ 1, "asc" ]], "bPaginate": false } ) ); - - $("#CheckAll").click(function(){ - $(".checkboxed").checkCheckboxes(); - return false; - }); - $("#CheckNone").click(function(){ - $(".checkboxed").unCheckCheckboxes(); - return false; - }); - - $("#closemenu").click(function(e){ - $(".linktools").hide(); - $("tr").removeClass("selected"); - }); - $("#resetZ3950Search").click(function(e) { - e.preventDefault(); - $("form[name='f']").find("input[type=text]").val(""); - }); - /* Inline edit/delete links */ $("td").click(function(event){ var $tgt = $(event.target); @@ -64,27 +45,13 @@ $("#dataPreviewLabel").html(""); $("#dataPreview .modal-body").html("
\"\" "+_("Loading")+"
"); }); -}); - -[% IF ( total_pages ) %] -function validate_goto_page(){ - var page = $('#goto_page').val(); - if(isNaN(page)) { - alert(_("The page entered is not a number.")); - return false; - } - else if(page < 1 || page > [% total_pages %] ) { - alert(_("The page should be a number between 1 and %s.").format([% total_pages %])); - return false; - } - else { - return true; - } -} -[% END %] +}); + var MSG_CHOOSE_Z3950 = _("Please choose at least one external target"); //]]> +[% INCLUDE 'z3950_search.inc' %] +