Bugzilla – Attachment 53045 Details for
Bug 15128
Add ability to limit the number of open purchase suggestions a patron can make
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15128: Do not display "New suggestion" if limit has just been reached
Bug-15128-Do-not-display-New-suggestion-if-limit-h.patch (text/plain), 1.19 KB, created by
Jonathan Druart
on 2016-07-01 16:04:24 UTC
(
hide
)
Description:
Bug 15128: Do not display "New suggestion" if limit has just been reached
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-07-01 16:04:24 UTC
Size:
1.19 KB
patch
obsolete
>From a9894beaf3f4dfd92d2c0890ba80dac60d68ab8e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 1 Jul 2016 17:00:39 +0100 >Subject: [PATCH] Bug 15128: Do not display "New suggestion" if limit has just > been reached > >If limit is X and patrons has X-1 pending suggestions, when a new one is >added, the "New suggestion" should not been added. >to avoid another call to SearchSuggestions, we assume than the >suggestion has been correctly added. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > opac/opac-suggestions.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl >index 1cc96c2..628f864 100755 >--- a/opac/opac-suggestions.pl >+++ b/opac/opac-suggestions.pl >@@ -148,6 +148,7 @@ if ( $op eq "add_confirm" ) { > $suggestion->{branchcode} = $input->param('branchcode') || C4::Context->userenv->{"branch"}; > > &NewSuggestion($suggestion); >+ $patrons_pending_suggestions_count++; > > # delete empty fields, to avoid filter in "SearchSuggestion" > foreach my $field ( qw( title author publishercode copyrightdate place collectiontitle isbn STATUS ) ) { >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15128
:
52452
|
52502
|
52596
|
52610
|
52611
|
52623
|
52624
|
52625
|
52626
|
52715
|
52716
|
52717
|
52718
|
52719
|
52720
|
52721
|
52722
|
52997
|
53033
|
53034
|
53037
|
53038
|
53039
|
53040
|
53041
|
53042
|
53043
|
53044
| 53045