From 2bb8267e3aae682877bee706df81957a3e24fff8 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Tue, 5 Jul 2016 22:38:08 -0400 Subject: [PATCH] Bug 16856 - unimarc plugin 4xx template noise While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was run. This triggers UNIMARC 4xx plugin noise. The issue is that itypeloo.selected is not a property that exists in the hash parameter to the template. git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po: The above was used to confirm that there is only one file which affects that template: cataloguing/value_builder/unimarc_field_4XX.pl There is only one way for the Search value to evaluate to true: the else case of the $op check (right at the bottom of the file). The value passed to the itypeloop parameter is a full search from Koha::ItemTypes->search, which has no parameters passed to it, and does not return a 'selected' key as part of the array of hashes. The logic to try to set "selected" in the template makes no sense, as a result, since it is only called with a value that never has "selected" set. The fix is easy: cut the useless code. TEST PLAN --------- 1) prove t/db_dependent/FrameworkPlugin.t -- see unimarc 4xx related noise. 2) apply patch 3) prove t/db_dependent/FrameworkPlugin.t -- no more unimarc 4xx related noise. 4) run koha qa test tools --- .../prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt index 458c199..b784c3a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt @@ -129,12 +129,8 @@

-- 2.1.4