From 952f3f650f449abf292d37dbe455e9a63a72e07f Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Thu, 23 Jun 2016 19:20:41 -0400 Subject: [PATCH] Bug 3311: Statistical reports should error if row and column aren't selected There are three parameters to play with which do not always generate friendly results. A couple of them seriously crash now. TEST PLAN --------- 1) Staff -> Reports -> Catalog -- should be at 'Catalog statistics' area. 2) Run through combinations: no row, no column no row, column row, no column row, column After selecting a combination to test, click submit, see what happens. Pre-patch apply, nasty crashes sometimes. Step 1 may require repeating, since you can't select a radio button and then unselect it. 3) Apply the patch 4) Repeat the first two steps again, and this time, a pretty informational or warning message should be given. 5) Run koha qa test tools Signed-off-by: Nicole C Engard --- .../prog/en/modules/reports/catalogue_stats.tt | 45 ++++++++++++++++- reports/catalogue_stats.pl | 59 ++++++++++++++++++---- 2 files changed, 92 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt index 7e04361..0ef130a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt @@ -4,6 +4,25 @@ [% INCLUDE 'calendar.inc' %]