Bugzilla – Attachment 53219 Details for
Bug 10407
Allow MARCXML records to be imported with Tools/Stage MARC records for import
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10407: Resolve warnings from child process
Bug-10407-Resolve-warnings-from-child-process.patch (text/plain), 1.28 KB, created by
Marcel de Rooy
on 2016-07-08 11:40:16 UTC
(
hide
)
Description:
Bug 10407: Resolve warnings from child process
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-07-08 11:40:16 UTC
Size:
1.28 KB
patch
obsolete
>From 8f713cfcba3aac6427424975f6d4595edbe17f28 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 8 Jul 2016 08:34:00 +0200 >Subject: [PATCH] Bug 10407: Resolve warnings from child process >Content-Type: text/plain; charset=utf-8 > >After the staging job finishes, the child tries to print results to >STDOUT (which is closed). This creates warnings like: > >stage-marc-import.pl: binmode() on closed filehandle STDOUT at C4/Templates.pm line 120. >stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/lib/perl5/Template/Provider.pm line 964. > >Resolving it is simple: the child should exit after marking the job >as finished. > >Test plan: >Import a marc file. >Observe that you do no longer have such warnings. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > tools/stage-marc-import.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/tools/stage-marc-import.pl b/tools/stage-marc-import.pl >index e7e9954..f353abd 100755 >--- a/tools/stage-marc-import.pl >+++ b/tools/stage-marc-import.pl >@@ -175,6 +175,7 @@ if ($completedJobID) { > }; > if ($runinbackground) { > $job->finish($results); >+ exit 0; > } else { > $template->param(staged => $num_valid, > matched => $num_with_matches, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10407
:
38101
|
38127
|
38129
|
38133
|
42831
|
53164
|
53165
|
53218
|
53219
|
53220
|
53221
|
53223
|
53306
|
53765
|
53766
|
53767
|
53768
|
53769
|
53937
|
53938
|
53939
|
53940
|
53941