Bugzilla – Attachment 53400 Details for
Bug 16681
Allow update of opacnote via batch patron modification tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16681 - Allow update of opacnote via batch patron modification tool
Bug-16681---Allow-update-of-opacnote-via-batch-pat.patch (text/plain), 4.44 KB, created by
Nick Clemens
on 2016-07-14 15:51:34 UTC
(
hide
)
Description:
Bug 16681 - Allow update of opacnote via batch patron modification tool
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2016-07-14 15:51:34 UTC
Size:
4.44 KB
patch
obsolete
>From b8fccf3cb21b719bafe1afb5736e08e8905ca5e8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 14 Jul 2016 11:45:54 -0400 >Subject: [PATCH] Bug 16681 - Allow update of opacnote via batch patron > modification tool > >To test: >1 - Select a batch of patrons (via list, saved file, and cardnumber > entry) >2 - Verify you cannot edit 'opacnotes' field, nor can you see >'borrowernotes' field in table, though you can edit it >3 - Verify editing works as expected >4 - Apply patch >5 - Select a batch via each method as above >6 - Note both note columns display in table >7 - Note that you can edit or clear the opacnotes field as expected >8 - Verify other feautres work as previously > >Sponsored by: > Lancaster Theological Seminary (https://lancasterseminary.edu/) > >https://bugs.koha-community.org/show_bug.cgi?id=15975 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 6 ++++++ > tools/modborrowers.pl | 8 +++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index 51775a2..a9efac8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -239,6 +239,8 @@ > <th>Country</th> > <th class="title-string">Registration date</th> > <th class="title-string">Expiry date</th> >+ <th>Circulation note</th> >+ <th>Opac Note</th> > [% FOREACH attrh IN attributes_header %] > <th>[% attrh.attribute %]</th> > [% END %] >@@ -261,6 +263,8 @@ > <td>[% borrower.country %]</td> > <td><span title="[% borrower.dateenrolled %]">[% borrower.dateenrolled | $KohaDates %]</span></td> > <td><span title="[% borrower.dateexpiry %]">[% borrower.dateexpiry | $KohaDates %]</span></td> >+ <td>[% borrower.borrowernotes %]</td> >+ <td>[% borrower.opacnote %]</td> > [% FOREACH pa IN borrower.patron_attributes %] > [% IF ( pa.code ) %] > <td>[% pa.code %]=[% pa.value %]</td> >@@ -315,6 +319,8 @@ > Expiry date: > [% CASE 'borrowernotes' %] > Circulation note: >+ [% CASE 'opacnote' %] >+ OPAC note: > [% END %] > </label> > [% IF field.mandatory %] >diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl >index c776406..6416343 100755 >--- a/tools/modborrowers.pl >+++ b/tools/modborrowers.pl >@@ -247,6 +247,12 @@ if ( $op eq 'show' ) { > type => "text", > mandatory => ( grep /borrowernotes/, @mandatoryFields ) ? 1 : 0, > } >+ , >+ { >+ name => "opacnote", >+ type => "text", >+ mandatory => ( grep /opacnote/, @mandatoryFields ) ? 1 : 0, >+ } > ); > > $template->param('patron_attributes_codes', \@patron_attributes_codes); >@@ -260,7 +266,7 @@ if ( $op eq 'do' ) { > > my @disabled = $input->multi_param('disable_input'); > my $infos; >- for my $field ( qw/surname firstname branchcode categorycode city state zipcode country sort1 sort2 dateenrolled dateexpiry borrowernotes/ ) { >+ for my $field ( qw/surname firstname branchcode categorycode city state zipcode country sort1 sort2 dateenrolled dateexpiry borrowernotes opacnote/ ) { > my $value = $input->param($field); > $infos->{$field} = $value if $value; > $infos->{$field} = "" if grep { /^$field$/ } @disabled; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16681
:
53400
|
53414
|
53437