Bugzilla – Attachment 5347 Details for
Bug 6770
AllowHoldPolicyOverride not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride
SIGNED-OFF-bug6770-removed-doubled-override-increm.patch (text/plain), 1.99 KB, created by
Nicole C. Engard
on 2011-09-08 00:06:35 UTC
(
hide
)
Description:
[SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-09-08 00:06:35 UTC
Size:
1.99 KB
patch
obsolete
>From 215d08e34fb1da740547688ea60ead1159e6d042 Mon Sep 17 00:00:00 2001 >From: Srdjan Jankovic <srdjan@catalyst.net.nz> >Date: Tue, 6 Sep 2011 16:07:49 +1200 >Subject: [PATCH] [SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > reserve/request.pl | 16 ++++++---------- > 1 files changed, 6 insertions(+), 10 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 0c952b4..71762f8 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -434,22 +434,18 @@ foreach my $biblionumber (@biblionumbers) { > $policy_holdallowed = 0; > } > >- if (IsAvailableForItemLevelRequest($itemnumber) and >- not $item->{cantreserve} and >- CanItemBeReserved($borrowerinfo->{borrowernumber}, $itemnumber) ) { >- if ( $policy_holdallowed ) { >+ if ( $policy_holdallowed && >+ !$item->{cantreserve} && >+ IsAvailableForItemLevelRequest($itemnumber) && >+ CanItemBeReserved($borrowerinfo->{borrowernumber}, $itemnumber) >+ ) { > $item->{available} = 1; > $num_available++; >- } > } elsif (C4::Context->preference( 'AllowHoldPolicyOverride' ) ) { >+ # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules > $item->{override} = 1; > $num_override++; > } >- # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules >- if (C4::Context->preference( 'AllowHoldPolicyOverride' ) && !$item->{available} ) { >- $item->{override} = 1; >- $num_override++; >- } > > # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked > >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6770
:
5313
|
5347
|
5819