Bugzilla – Attachment 53477 Details for
Bug 16871
Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt
SIGNED-OFFBug-16871-Translatability-Avoid--problem.patch (text/plain), 4.20 KB, created by
Héctor Eduardo Castro Avalos
on 2016-07-18 17:10:15 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-07-18 17:10:15 UTC
Size:
4.20 KB
patch
obsolete
>From 2d96436ab4842524626e1d910ea8eaa7090a14fe Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Tue, 5 Jul 2016 07:14:26 +0200 >Subject: [PATCH] [SIGNED-OFF]Bug 16871: Translatability: Avoid [%%-problem > and fix related sentence splitting in catalogue/detail.tt > >In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, >fix line splitted TT directives and sentence splitting leading >to translatability problems. (See first comment). > >To test: >- Apply patch >- Go to detail pages of biblios with waiting holds >- Verify that messages in column 'Status' are OK >- Examine code in patch to make sure that the simplification in logic > makes sense and that no TT directive is splitted >- Bonus test: > - Go to folder misc/translator. Run perl translate create xx-XX > - Verify that monster mentioned in first comment no longer exists > (in po/xx-XX-staff-prog.po) > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > .../prog/en/modules/catalogue/detail.tt | 30 ++++---------------- > 1 file changed, 5 insertions(+), 25 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index e8de754..26c7070 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -691,41 +691,21 @@ function verify_images() { > > [% IF ( item.reservedate ) %] > [% IF ( item.waitingdate ) %] >- Waiting >+ Waiting since [% item.waitingdate | $KohaDates %] at [% item.ExpectedAtLibrary %]. > [% ELSE %] >- Item-level hold >+ Item-level hold (placed [% item.reservedate | $KohaDates %]) for delivery at [% item.ExpectedAtLibrary %]. > [% END %] > [% IF ( canreservefromotherbranches ) %] >- for <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.ReservedForBorrowernumber %]"> >+ Hold for: <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.ReservedForBorrowernumber %]"> > [% IF ( item.hidepatronname ) %] > [% item.Reservedcardnumber %] > [% ELSE %] >- [% item.ReservedForFirstname %] [% item.ReservedForSurname %] >+ [% item.ReservedForFirstname _ item.ReservedForSurname _ " (" _ item.Reservedcardnumber _ ")" %] > [% END %] > </a> > [% END %] >- [% IF ( item.waitingdate ) %] >- at[% ELSE %]for delivery at >- [% END %] >- [% item.ExpectedAtLibrary %] >- [% IF ( item.waitingdate ) %] >- since [% item.waitingdate | $KohaDates %] >- [% ELSE %] >- [% IF ( item.reservedate ) %] >- (placed [% item.reservedate | $KohaDates %]) >- [% END %] >- [% END %] > [% END %] >- [% UNLESS ( >- item.itemnotforloan >- or item.notforloan_per_itemtype >- or item.onloan >- or item.itemlost >- or item.withdrawn >- or item.damaged >- or item.transfertwhen >- or item.reservedate >- ) %] >+ [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || item.reservedate ) %] > Available > [% END %] > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16871
:
53184
|
53477
|
53719
|
53838