Bugzilla – Attachment 53491 Details for
Bug 16449
unimarc_field_4XX raises a warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16449: Remove "no method selected" warning from unimarc_field_4XX
Bug-16449-Remove-no-method-selected-warning-from-u.patch (text/plain), 1.79 KB, created by
Mark Tompsett
on 2016-07-19 14:59:04 UTC
(
hide
)
Description:
Bug 16449: Remove "no method selected" warning from unimarc_field_4XX
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-07-19 14:59:04 UTC
Size:
1.79 KB
patch
obsolete
>From bd690af1a0bd256d8404ebd2991cff33f28f0129 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 5 May 2016 15:25:50 +0100 >Subject: [PATCH] Bug 16449: Remove "no method selected" warning from > unimarc_field_4XX > >Because of bug 14828, the unimarc_field_4XX now raises a warning: >"No method selected!" > >There are no need to select an item type on this page, the default (all) >is always selected. > >Test plan: >Link the unimarc_field_4XX value builder with on of the subfield >Edit a record, click on the value builder icon >Note the warning without the patch and that it's gone with the patch >applied > >NOTE: Code fix that I derived was identical. Ran > prove t/db_dependent/FrameworkPlugin.t >to confirm it works. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > .../prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >index 458c199..b784c3a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >@@ -129,12 +129,8 @@ > <select name="itype" id="itypeloop"> > <option value="">All item types</option> > [% FOREACH itypeloo IN itypeloop %] >- [% IF ( itypeloo.selected ) %] >- <option value="[% itypeloo.itemtype %]" selected="selected">[% itypeloo.description |html %]</option> >- [% ELSE %] > <option value="[% itypeloo.itemtype %]">[% itypeloo.description |html %]</option> > [% END %] >- [% END %] > </select> > </p> > <p> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16449
:
51238
|
53491
|
55109