Bugzilla – Attachment 53501 Details for
Bug 16944
Add "email" and "url" classes when edit or create a vendor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16944: Add "email" and "url" classes when edit or create a vendor
Bug-16944-Add-email-and-url-classes-when-edit-or-c.patch (text/plain), 3.02 KB, created by
Héctor Eduardo Castro Avalos
on 2016-07-19 21:15:53 UTC
(
hide
)
Description:
Bug 16944: Add "email" and "url" classes when edit or create a vendor
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-07-19 21:15:53 UTC
Size:
3.02 KB
patch
obsolete
>From 9e62379b297752daae8b485ec1ac4d209ce1197c Mon Sep 17 00:00:00 2001 >From: Hector Castro <hector.hecaxmmx@gmail.com> >Date: Tue, 19 Jul 2016 14:58:58 -0600 >Subject: [PATCH] Bug 16944: Add "email" and "url" classes when edit or create > a vendor > >When edit or create a new vendor the two fields "email" and "website" don't test >if the data provided is right. When you add a direction like >"koha-community.org" without the protocol "https" the program redirect to an >404 error. > >To reproduce the issue: >1-Go to Acquisition and create a new Vendor >2-Fill the field Website with koha-community.org >3-Use an email without at sing (@) >4-Notice that there is no error >5-Save >6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) >7-Click in Website: koha-community.org -> redirect to an 404 error >8-Notice the bad mailto: > >To test: >-Apply patch >-Reproduce step 1 to 8 with the same vendor or create a new one >-Enter multiple wrong and valid urls >-Enter urls with and without protocols http, https, ftp >-Enter wrong and valid emails > >NOTE: The classes used are taken from 'branches.tt' >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 72302da..02e143a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -13,7 +13,7 @@ > <li><label for="contact_fax[% contact.id %]">Fax: </label> > <input type="text" size="20" id="contact_fax[% contact.id %]" name="contact_fax" value="[% contact.fax %]" /></li> > <li><label for="contact_email[% contact.id %]">Email: </label> >- <input type="text" size="40" id="contact_email[% contact.id %]" name="contact_email" value="[% contact.email %]" /></li> >+ <input type="text" size="40" id="contact_email[% contact.id %]" name="contact_email" value="[% contact.email %]" class="email" /></li> > <li><label for="contact_notes[% contact.id %]">Notes: </label> > <textarea id="contact_notes[% contact.id %]" name="contact_notes" cols="40" rows="4">[% contact.notes %]</textarea></li> > <li><label for="contact_acqprimary[% contact.id %]">Primary acquisitions contact:</label> >@@ -188,7 +188,7 @@ function delete_contact(ev) { > <li><label for="company_fax">Fax: </label> > <input type="text" size="20" id="company_fax" name="company_fax" value="[% fax %]" /></li> > <li><label for="website">Website: </label> >- <input type="text" size="40" id="website" name="website" value="[% url %]" /></li> >+ <input type="text" size="40" id="website" name="website" value="[% url %]" class="url" /></li> > <li><label for="accountnumber">Account number: </label> > <input type="text" size="40" id="accountnumber" name="accountnumber" value="[% accountnumber %]" /></li></ol> > </fieldset> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16944
:
53501
|
53504
|
53683