Bugzilla – Attachment 53593 Details for
Bug 16947
Can not modify patron messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16947: Can not modify patron messaging preferences
Bug-16947-Can-not-modify-patron-messaging-preferen.patch (text/plain), 2.06 KB, created by
Jonathan Druart
on 2016-07-21 16:27:56 UTC
(
hide
)
Description:
Bug 16947: Can not modify patron messaging preferences
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-07-21 16:27:56 UTC
Size:
2.06 KB
patch
obsolete
>From fd4a427c00e057fae93ca3e7a7a98b27ebd1c70f Mon Sep 17 00:00:00 2001 >From: Marc <veron@veron.ch> >Date: Thu, 21 Jul 2016 10:22:57 +0200 >Subject: [PATCH] Bug 16947: Can not modify patron messaging preferences > >To verify: >- Set syspref 'EnhancedMessagingPreferences' to 'Allow' >- In staff client, go to a patron's detail page >- Edit Patron messaging preferences (using link below table) >- Save >Result: Form does not save, stays open >JavaScript error in intranet-tmpl/prog/js/members.js line 107 >TypeError: document.form.password is undefined > >To test: >- Apply patch >- Repeat steps above >- Verify that messaging preferences save as expected >- Verify that other patron modifications work as before > >NOTE: remember to force reload of the javascripts. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/js/members.js | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/members.js b/koha-tmpl/intranet-tmpl/prog/js/members.js >index d300d92..c90d8af 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/members.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/members.js >@@ -103,18 +103,19 @@ function check_form_borrowers(nav){ > } > } > } >- >- if ( document.form.password.value != document.form.password2.value ){ >+ if ( document.form.password ) { >+ if ( document.form.password.value != document.form.password2.value ){ > if ( message_champ !== '' ){ > message_champ += "\n"; > } > message_champ+= MSG_PASSWORD_MISMATCH; > statut=1; >- } >+ } > >- if ( ! check_password( document.form.password.value ) ) { >- message_champ += MSG_PASSWORD_CONTAINS_TRAILING_SPACES; >- statut = 1; >+ if ( ! check_password( document.form.password.value ) ) { >+ message_champ += MSG_PASSWORD_CONTAINS_TRAILING_SPACES; >+ statut = 1; >+ } > } > > //patrons form to test if you checked no to the question of double >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16947
:
53553
|
53564
| 53593