Bugzilla – Attachment 53840 Details for
Bug 17010
Canceling a hold awaiting pickup no longer alerts librarian about next hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17010 - Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold
Bug-17010---Canceling-a-hold-that-has-been-waiting.patch (text/plain), 3.39 KB, created by
Kyle M Hall
on 2016-08-01 14:25:56 UTC
(
hide
)
Description:
Bug 17010 - Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2016-08-01 14:25:56 UTC
Size:
3.39 KB
patch
obsolete
>From 6ed236053f885c05f1e7e1af6cbcc78357f95cba Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 1 Aug 2016 07:17:04 -0700 >Subject: [PATCH] Bug 17010 - Canceling a hold that has been waiting too long > from Holds Awaiting Pickup no longer alerts librarian about next hold > >In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, >the librarian would be alerted with the message "This item is on hold for pick-up at your library" >and directed to check it in to fill the next hold. This no longer happens. > >Test Plan: >1) Apply this patch >2) Find a hold that has been waiting too long >3) Cancel that hold via waitingreserves.pl >4) Note you get the message "This item is on hold for pick-up at your library" >5) Confirm the ok button redirects you to the correct tab >--- > circ/waitingreserves.pl | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > >diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl >index 0050ce3..603dbc5 100755 >--- a/circ/waitingreserves.pl >+++ b/circ/waitingreserves.pl >@@ -162,9 +162,10 @@ $template->param( > overcount => $overcount, > show_date => output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), > ReservesMaxPickUpDelay => $max_pickup_delay, >+ tab => $tab, > ); > >-if ($item && $tab eq 'holdsover') { >+if ($item && $tab eq 'holdsover' && !@cancel_result) { > print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl#holdsover"); > } elsif ($cancelall) { > print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl"); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index 3183442..5bcf6cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -51,8 +51,8 @@ > <p><strong>[% nextreservtitle %]</strong> is on hold for <strong> [% nextreservsurname %], [% nextreservfirstname %]</strong>. > Please retain this item and check it in to process the hold. > </p> >- <form name="cancelReservewithtransfert" action="waitingreserves.pl" method="post"> >- <input type="submit" class="submit" value="OK" /> >+ <form name="cancelReservewithtransfert" action="waitingreserves.p#[% tab %]" method="post"> >+ <input class="btn" type="submit" class="submit" value="OK" /> > </form> > </div> > [% END %] >@@ -62,8 +62,8 @@ > <p><strong>[% nextreservtitle %]</strong> is on hold for <strong>[% nextreservsurname %], [% nextreservfirstname %]</strong>. > Please retain this item and check it in to process the hold. > </p> >- <form name="cancelReservewithwaiting" action="waitingreserves.pl" method="post"> >- <input type="submit" class="submit" value="OK"/> >+ <form name="cancelReservewithwaiting" action="waitingreserves.pl#[% tab %]" method="post"> >+ <input class="btn" type="submit" class="submit" value="OK"/> > </form> > </div> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17010
:
53840
|
54241
|
54242
|
55387
|
55459
|
55460
|
58052