Bugzilla – Attachment 53931 Details for
Bug 17026
checkexpiration.pl is vulnerable to XSS attacks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17026: Fix XSS in serials/checkexpiration.pl
Bug-17026-Fix-XSS-in-serialscheckexpirationpl.patch (text/plain), 2.12 KB, created by
Chris Cormack
on 2016-08-03 05:20:17 UTC
(
hide
)
Description:
Bug 17026: Fix XSS in serials/checkexpiration.pl
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2016-08-03 05:20:17 UTC
Size:
2.12 KB
patch
obsolete
>From 8d9883a05443ddf37365cc2165740df3585eee17 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 Aug 2016 14:51:49 +0100 >Subject: [PATCH] Bug 17026: Fix XSS in serials/checkexpiration.pl > >Test plan: >Hit: > /serials/checkexpiration.pl?title="><script>alert("XSS")</script>&date=12/02/2002 > /serials/checkexpiration.pl?issn="><script>alert("XSS")</script>&date=12/02/2002 > >=> Without this patch you will see the alert >=> With this patch, no more alert > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../intranet-tmpl/prog/en/modules/serials/checkexpiration.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >index 8b69320..5e573ff 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >@@ -49,10 +49,10 @@ > > <ol> > <li><label for="title">Title:</label> >- <input id="title" type="text" name="title" size="15" value="[% title %]" /></li> >+ <input id="title" type="text" name="title" size="15" value="[% title | html %]" /></li> > > <li><label for="issn">ISSN:</label> >- <input id="issn" type="text" name="issn" size="15" value="[% issn %]" /></li> >+ <input id="issn" type="text" name="issn" size="15" value="[% issn | html %]" /></li> > [% IF (branches_loop.size) %] > <li><label for="branch">Library:</label> > <select id="branch" name="branch"> >@@ -84,11 +84,11 @@ > <p> > <b>[% numsubscription %]</b> subscription(s) > [% IF ( title ) %] >- with title matching <span class="title">[% title %]</class> >+ with title matching <span class="title">[% title | html %]</class> > [% IF ( issn ) %]and [% END %] > [% END %] > [% IF ( issn ) %] >- with ISSN matching <b>[% issn %]</b> >+ with ISSN matching <b>[% issn | html %]</b> > [% END %] > will expire before <b>[% date | $KohaDates %]</b> > </p> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17026
:
53912
|
53931
|
53978