Bugzilla – Attachment 54062 Details for
Bug 17053
Clearing search term in Reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17053 Clearing search term in Reports
Bug-17053-Clearing-search-term-in-Reports.patch (text/plain), 1.46 KB, created by
Frédéric Demians
on 2016-08-06 08:14:03 UTC
(
hide
)
Description:
Bug 17053 Clearing search term in Reports
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2016-08-06 08:14:03 UTC
Size:
1.46 KB
patch
obsolete
>From 19ef7027f9b4bf5e7bfcc0ef374582e013fb90f8 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Sat, 6 Aug 2016 10:13:18 +0200 >Subject: [PATCH] Bug 17053 Clearing search term in Reports > >If you click the clear button to clear the search term it does take the search >term away. However, the next time you click on "Saved reports" the search term >is still there. > >TO TEST: > >1. Reports > Use saved >2. Filter on anything (date/author/keyword). Let say "foo" in keyword. >3. Click the Clear link on the Filter form. You can see that "foo" is removed > from keyword, and all the saved reports are displayed. >4. Click "Saved Reports" on the left. You can see that "foo" reappears in > keyword filter. >5. Apply the patch, and repeat steps 2-4. >--- > reports/guided_reports.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 75040f4..a825707 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -73,7 +73,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > my $session = $cookie ? get_session($cookie->value) : undef; > > my $filter; >-if ( $input->param("filter_set") ) { >+if ( $input->param("filter_set") or $input->param('clear_filters') ) { > $filter = {}; > $filter->{$_} = $input->param("filter_$_") foreach qw/date author keyword group subgroup/; > $session->param('report_filter', $filter) if $session; >-- >2.9.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17053
:
54062
|
54067
|
54118