From 1d83392376149f46f8ebd01e084d6c9e94ae1db4 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 4 Aug 2016 14:37:11 -0400 Subject: [PATCH] [PASSED QA] Bug 17057 - Remove event attributes from holds template This patch removes event attributes from the holds template. Events are defined instead in the JavaScript. Also changed: Move formatting of hold date to the template; Corrected a non-functional 'cancel hold' link. To test apply the patch and: - Start the process of placing a hold on a single title for a patron. - Uncheck 'Place a hold on the next available item' and try to submit the form without selecting an item. You should be prompted to select an item. - Place a hold on multiple titles at the same time. Confirm that your hold is saved correctly. - View the holds for a title which has multiple holds. - Confirm that clicking the "X" image triggers a confirmation. Test canceling and confirming. - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for any hold and confirm that the corresponding 'Clear date' link works correctly. - Confirm that suspending a hold with and without an expiration date works correctly. - Place an item-level hold. - View the holds for that same title. - Submit another patron to place a new hold. - In the list of items which can be placed on hold, look for the item you place on hold previously. There should be a "Cancel hold" link in the information column. Confirm that this link correctly triggers a confirmation dialog and deletes the hold. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer --- .../prog/en/modules/reserve/request.tt | 55 ++++++++++++++++++---- reserve/request.pl | 3 +- 2 files changed, 47 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index ba53b3a..bf0b024 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -15,7 +15,6 @@ [% INCLUDE 'calendar.inc' %]