View | Details | Raw Unified | Return to bug 17089
Collapse All | Expand All

(-)a/Koha/Rating.pm (+15 lines)
Lines 33-38 Koha::Rating - Koha Rating Object class Link Here
33
33
34
=cut
34
=cut
35
35
36
=head3 store
37
38
=cut
39
40
sub store {
41
    my ($self) = @_;
42
    if ( $self->rating_value > 5 ) {
43
        $self->rating_value(5);
44
    }
45
    elsif ( $self->rating_value < 0 ) {
46
        $self->rating_value(0);
47
    }
48
    return $self->SUPER::store;
49
}
50
36
=head3 type
51
=head3 type
37
52
38
=cut
53
=cut
(-)a/t/db_dependent/Koha/Ratings.t (-2 / +9 lines)
Lines 17-23 Link Here
17
17
18
use Modern::Perl;
18
use Modern::Perl;
19
19
20
use Test::More tests => 4;
20
use Test::More tests => 6;
21
21
22
use Koha::Database;
22
use Koha::Database;
23
use Koha::Rating;
23
use Koha::Rating;
Lines 43-48 $rating_1->rating_value(5)->store; Link Here
43
43
44
is( Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating, 4.5, );
44
is( Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating, 4.5, );
45
45
46
$rating_1->rating_value(42)->store;
47
is( Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_1->{borrowernumber} } )->rating_value,
48
    5, 'Koha::Ratings->store should mark out the boundaries of the rating values, 5 is max' );
49
50
$rating_1->rating_value(-42)->store;
51
is( Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_1->{borrowernumber} } )->rating_value,
52
    0, 'Koha::Ratings->store should mark out the boundaries of the rating values, 0 is min' );
53
46
Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_1->{borrowernumber} } )->delete;
54
Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_1->{borrowernumber} } )->delete;
47
Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_2->{borrowernumber} } )->delete;
55
Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_2->{borrowernumber} } )->delete;
48
is( Koha::Ratings->search( { biblionumber => $biblionumber } )->count, 0, 'Delete should have deleted the ratings' );
56
is( Koha::Ratings->search( { biblionumber => $biblionumber } )->count, 0, 'Delete should have deleted the ratings' );
49
- 

Return to bug 17089