Bugzilla – Attachment 54341 Details for
Bug 17089
Move the star ratings related code to Koha::Ratings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17089: [QA Follow-up] Add some test descriptions to Ratings.t
Bug-17089-QA-Follow-up-Add-some-test-descriptions-.patch (text/plain), 1.56 KB, created by
Marcel de Rooy
on 2016-08-12 08:19:14 UTC
(
hide
)
Description:
Bug 17089: [QA Follow-up] Add some test descriptions to Ratings.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-08-12 08:19:14 UTC
Size:
1.56 KB
patch
obsolete
>From 6f69211ffd71fe97ac2aebd39e99fc5148edefce Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 12 Aug 2016 10:12:18 +0200 >Subject: [PATCH] Bug 17089: [QA Follow-up] Add some test descriptions to > Ratings.t >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/Ratings.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Ratings.t b/t/db_dependent/Koha/Ratings.t >index 2f8ead9..cc2c5cc 100755 >--- a/t/db_dependent/Koha/Ratings.t >+++ b/t/db_dependent/Koha/Ratings.t >@@ -37,11 +37,11 @@ my $biblionumber = $biblio_1->{biblionumber}; > my $rating_1 = Koha::Rating->new( { biblionumber => $biblionumber, borrowernumber => $patron_1->{borrowernumber}, rating_value => 3 } )->store; > my $rating_2 = Koha::Rating->new( { biblionumber => $biblionumber, borrowernumber => $patron_2->{borrowernumber}, rating_value => 4 } )->store; > >-is( Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating, 3.5, ); >+is( Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating, 3.5, 'get_avg_rating is 3.5' ); > > $rating_1->rating_value(5)->store; > >-is( Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating, 4.5, ); >+is( Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating, 4.5, 'get_avg_rating now up to 4.5' ); > > $rating_1->rating_value(42)->store; > is( Koha::Ratings->find( { biblionumber => $biblionumber, borrowernumber => $patron_1->{borrowernumber} } )->rating_value, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17089
:
54207
|
54208
|
54209
|
54210
|
54211
|
54212
|
54213
|
54214
|
54225
|
54230
|
54231
|
54232
|
54233
|
54234
|
54235
|
54236
|
54237
|
54238
|
54332
|
54333
|
54334
|
54335
|
54336
|
54337
|
54338
|
54339
|
54340
| 54341