From 9d7eff94287b42d61f7c1dd60dcd20cdc4e350ad Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 12 Aug 2016 13:26:46 +0200 Subject: [PATCH] Bug 15407: [QA Follow-up] Confusing cathash removed Content-Type: text/plain; charset=utf-8 One of the patches removed %cathash. Some kind of silly remainder was left in a string. Just used as a text field to explain the filters used on borrowers_stats.pl. The filter name cathash is not really easy and also was confusing in relation to the variable. So just a string patch, replacing it with Patron category. NOTE: The output of borrowers_stats.pl with the filters listed, is not one of the most beautiful Koha screens. Furthermore, translatibility of these filters is still an issue to be handled on another report. Signed-off-by: Marcel de Rooy --- reports/borrowers_stats.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl index 342dad4..a7e656f 100755 --- a/reports/borrowers_stats.pl +++ b/reports/borrowers_stats.pl @@ -260,7 +260,12 @@ sub calculate { $linefield = $line; } my $patron_categories = Koha::Patron::Categories->search({}, {order_by => ['categorycode']}); - push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map { $_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')'} $patron_categories->as_list )}; + push @loopfilter, + { + debug => 1, + crit => "Patron category", + filter => join( ", ", map { $_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')' } $patron_categories->as_list ), + }; my $strsth; my @strparams; # bind parameters for the query -- 1.7.10.4