Bugzilla – Attachment 54460 Details for
Bug 17124
DecreaseLoanHighHolds.t does not pass
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17124: Fix tests in DecreaseLoanHighHolds.t
Bug-17124-Fix-tests-in-DecreaseLoanHighHoldst.patch (text/plain), 1.52 KB, created by
Claire Gravely
on 2016-08-15 10:01:59 UTC
(
hide
)
Description:
Bug 17124: Fix tests in DecreaseLoanHighHolds.t
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2016-08-15 10:01:59 UTC
Size:
1.52 KB
patch
obsolete
>From 058e8bdd3163b0d96b660a9bfba0dc32d86f7ec8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 15 Aug 2016 09:26:16 +0100 >Subject: [PATCH] Bug 17124: Fix tests in DecreaseLoanHighHolds.t > >One test of DecreaseLoanHighHolds.t does not pass, >A hashref representing a patron has a 'borrower' key defined, instead of >'borrowernumber'. > >Test plan: > prove t/db_dependent/DecreaseLoanHighHolds.t >must return green > >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> >--- > t/db_dependent/DecreaseLoanHighHolds.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/DecreaseLoanHighHolds.t b/t/db_dependent/DecreaseLoanHighHolds.t >index ff56928..3eb8e6b 100755 >--- a/t/db_dependent/DecreaseLoanHighHolds.t >+++ b/t/db_dependent/DecreaseLoanHighHolds.t >@@ -108,7 +108,7 @@ C4::Context->set_preference( 'decreaseLoanHighHoldsControl', 'static' ); > C4::Context->set_preference( 'decreaseLoanHighHoldsIgnoreStatuses', 'damaged,itemlost,notforloan,withdrawn' ); > > my $item_hr = { itemnumber => $item->id, biblionumber => $biblio->id, homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, barcode => $item->barcode }; >-my $patron_hr = { borrower => $patron->id, branchcode => $library->{branchcode} }; >+my $patron_hr = { borrowernumber => $patron->id, branchcode => $library->{branchcode} }; > > my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr ); > is( $data->{exceeded}, 1, "Static mode should exceed threshold" ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17124
:
54453
|
54460
|
54476