From a9d05ff68460e6405c6e3a6e459bc020cc1af6cb Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 15 Aug 2016 15:45:38 +0100 Subject: [PATCH] Bug 17128: Make summary-print.pl plack safe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit $borrowernumber is used in build_issue_data but not correctly defined (Variable "$borrowernumber" is not available) That may cause wrong charge displayed in the summary slip. Test plan: - Set rental charge for an item type - Define a rental discount for that item type in the circ rules - check in an item matching this rule Without this patch the charge displayed in the summary slip won't be calculated with the discount With this patch applied, the warning in the logs will no longer appear and the values will be correctly calculated. Signed-off-by: Marc VĂ©ron --- members/summary-print.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/members/summary-print.pl b/members/summary-print.pl index f1933f5..30d9e4f 100755 --- a/members/summary-print.pl +++ b/members/summary-print.pl @@ -74,7 +74,7 @@ $template->param( accounts => $accts, totaldue => $total_format, - issues => build_issue_data( GetPendingIssues($borrowernumber) ), + issues => build_issue_data( $borrowernumber ), totalprice => $totalprice, reserves => build_reserve_data( $holds_rs ), @@ -83,7 +83,8 @@ $template->param( output_html_with_http_headers $input, $cookie, $template->output; sub build_issue_data { - my $issues = shift; + my ( $borrowernumber ) = @_; + my $issues = GetPendingIssues( $borrowernumber ); my $return = []; -- 2.1.4