Bugzilla – Attachment 54760 Details for
Bug 17142
Don't show library group selection in advanced search if groups are not defined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17142 - Don't show library group selection in advanced search if groups are not defined
Bug-17142---Dont-show-library-group-selection-in-a.patch (text/plain), 2.00 KB, created by
Jonathan Druart
on 2016-08-23 10:20:29 UTC
(
hide
)
Description:
Bug 17142 - Don't show library group selection in advanced search if groups are not defined
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-23 10:20:29 UTC
Size:
2.00 KB
patch
obsolete
>From b14536ee9412a075b8f93b311d50ce042428e450 Mon Sep 17 00:00:00 2001 >From: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Date: Wed, 17 Aug 2016 18:42:37 +0200 >Subject: [PATCH] Bug 17142 - Don't show library group selection in advanced > search if groups are not defined > >Even if library groups/search domains are not defined in the system, >(empty) select for "Groups of libraries" under "Location and >availability" section in OPAC advanced search is still visible; it >shouldn't. Side effect of Bug 15295 - 'searchdomainloop' variable >in the template is now an object, it needs a different kind of statement >(.count) for checking if it's empty or not. > >To test: > >1) apply patch >2) when there are no groups of libraries defined in Administration -> >Libraries and Groups, "Groups of libraries" selection should be >no longer visible in OPAC adavanced search page >3) add library group or two: "Groups of libraries" selection should >reappear. > >Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index 28591bd..c77742b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -222,7 +222,7 @@ > [% END %] > [% END %] > </select> >- [% IF ( searchdomainloop ) %] >+ [% IF ( searchdomainloop && searchdomainloop.count > 0) %] > <p>OR</p> > <label for="categoryloop">Groups of libraries</label> > <select name="multibranchlimit" id="categoryloop"> >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17142
:
54545
|
54727
| 54760