Bugzilla – Attachment 5483 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix 3 :utf8 for :encoding(UTF-8)
0001-fix-3-perl-critic-warnings.patch (text/plain), 1.92 KB, created by
Maxime Pelletier
on 2011-09-20 21:47:43 UTC
(
hide
)
Description:
fix 3 :utf8 for :encoding(UTF-8)
Filename:
MIME Type:
Creator:
Maxime Pelletier
Created:
2011-09-20 21:47:43 UTC
Size:
1.92 KB
patch
obsolete
>From d1a98d1fe493607a3e3d7832179988af4a50ab59 Mon Sep 17 00:00:00 2001 >From: Maxime Pelletier <maxime.pelletier@libeo.com> >Date: Tue, 20 Sep 2011 17:40:36 -0400 >Subject: [PATCH] fix 3 perl::critic warnings > >--- > circ/overdue.pl | 2 +- > circ/ypattrodue-attr-search-authvalue.pl | 2 +- > circ/ysearch.pl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/circ/overdue.pl b/circ/overdue.pl >index 18851a6..2bdafe1 100755 >--- a/circ/overdue.pl >+++ b/circ/overdue.pl >@@ -351,7 +351,7 @@ if ($noreport) { > } > > if ($op eq 'csv') { >- binmode(STDOUT, ":utf8"); >+ binmode(STDOUT, ":encoding(UTF-8)"); > my $csv = build_csv(\@overduedata); > print $input->header(-type => 'application/vnd.sun.xml.calc', > -encoding => 'utf-8', >diff --git a/circ/ypattrodue-attr-search-authvalue.pl b/circ/ypattrodue-attr-search-authvalue.pl >index 5ff1cd9..f8d77c5 100755 >--- a/circ/ypattrodue-attr-search-authvalue.pl >+++ b/circ/ypattrodue-attr-search-authvalue.pl >@@ -32,7 +32,7 @@ $attrcode =~ s|^/||; > my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { circulate => '*' } ); > exit 0 if $auth_status ne "ok"; > >-binmode STDOUT, ":utf8"; >+binmode STDOUT, ":encoding(UTF-8)"; > print $input->header( -type => 'text/plain', -charset => 'UTF-8' ); > > print STDERR ">> CALLING $0 (attrcode=$attrcode, query=$query)\n" if $debug; >diff --git a/circ/ysearch.pl b/circ/ysearch.pl >index f8fc52a..549a547 100755 >--- a/circ/ysearch.pl >+++ b/circ/ysearch.pl >@@ -33,7 +33,7 @@ use C4::Auth qw/check_cookie_auth/; > my $input = new CGI; > my $query = $input->param('query'); > >-binmode STDOUT, ":utf8"; >+binmode STDOUT, ":encoding(UTF-8)"; > print $input->header(-type => 'text/plain', -charset => 'UTF-8'); > > my ($auth_status, $sessionID) = check_cookie_auth($input->cookie('CGISESSID'), { circulate => '*' }); >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208