Bugzilla – Attachment 54834 Details for
Bug 17185
Staff client shows "Lists that include this title:" even if item is not in a list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list
Bug-17185-Staff-client-shows-Lists-that-include-th.patch (text/plain), 1.67 KB, created by
Nick Clemens (kidclamp)
on 2016-08-24 14:53:20 UTC
(
hide
)
Description:
Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-08-24 14:53:20 UTC
Size:
1.67 KB
patch
obsolete
>From 5b28f1bf27bced6b37af85b4a06c5c83da9350f1 Mon Sep 17 00:00:00 2001 >From: Andreas Roussos <arouss1980@gmail.com> >Date: Wed, 24 Aug 2016 17:10:29 +0300 >Subject: [PATCH] Bug 17185: Staff client shows "Lists that include this > title:" even if item is not in a list > >In the staff client, the text "Lists that include this title:" >is always shown, regardless of whether the item is in a list >or not. This patch fixes that. > >Test plan: >1) Log in to staff client. >2) Go to biblio details view: > /cgi-bin/koha/catalogue/detail.pl?biblionumber=X > Confirm that "Lists that include this title:" is > shown even if the item is not in a list. >3) Apply the patch. >4) Repeat step 2. Confirm that the patch works, i.e. > "Lists that include this title:" is only shown > for biblios that are actually in a list. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Only applies to non-XSLT view. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 0e4773d..7183ef4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -538,7 +538,7 @@ function verify_images() { > </li> > [% END %] > <!--This grabs all of the lists a bib record appears in --> >- [% IF shelves %] >+ [% IF shelves.count %] > <li><strong>Lists that include this title: </strong> > <ul> > [% FOREACH s IN shelves %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17185
:
54805
|
54830
|
54833
| 54834