View | Details | Raw Unified | Return to bug 10455
Collapse All | Expand All

(-)a/C4/Biblio.pm (-5 / +5 lines)
Lines 159-165 Biblio.pm contains functions for managing storage and editing of bibliographic d Link Here
159
159
160
=item 2. as raw MARC in the Zebra index and storage engine
160
=item 2. as raw MARC in the Zebra index and storage engine
161
161
162
=item 3. as raw MARC the biblioitems.marc and biblioitems.marcxml
162
=item 3. as MARC XML in biblioitems.marcxml
163
163
164
=back
164
=back
165
165
Lines 183-189 Because of this design choice, the process of managing storage and editing is a Link Here
183
183
184
=item 2. _koha_* - low-level internal functions for managing the koha tables
184
=item 2. _koha_* - low-level internal functions for managing the koha tables
185
185
186
=item 3. Marc management function : as the MARC record is stored in biblioitems.marc(xml), some subs dedicated to it's management are in this package. They should be used only internally by Biblio.pm, the only official entry points being AddBiblio, AddItem, ModBiblio, ModItem.
186
=item 3. Marc management function : as the MARC record is stored in biblioitems.marcxml, some subs dedicated to it's management are in this package. They should be used only internally by Biblio.pm, the only official entry points being AddBiblio, AddItem, ModBiblio, ModItem.
187
187
188
=item 4. Zebra functions used to update the Zebra index
188
=item 4. Zebra functions used to update the Zebra index
189
189
Lines 211-217 When dealing with items, we must : Link Here
211
211
212
=item 2. add the itemnumber to the item MARC field
212
=item 2. add the itemnumber to the item MARC field
213
213
214
=item 3. overwrite the MARC record (with the added item) into biblioitems.marc(xml)
214
=item 3. overwrite the MARC record (with the added item) into biblioitems.marcxml
215
215
216
When modifying a biblio or an item, the behaviour is quite similar.
216
When modifying a biblio or an item, the behaviour is quite similar.
217
217
Lines 232-239 framework code. Link Here
232
This function also accepts a third, optional argument: a hashref
232
This function also accepts a third, optional argument: a hashref
233
to additional options.  The only defined option is C<defer_marc_save>,
233
to additional options.  The only defined option is C<defer_marc_save>,
234
which if present and mapped to a true value, causes C<AddBiblio>
234
which if present and mapped to a true value, causes C<AddBiblio>
235
to omit the call to save the MARC in C<bibilioitems.marc>
235
to omit the call to save the MARC in C<bibilioitems.marcxml>
236
and C<biblioitems.marcxml>  This option is provided B<only>
236
This option is provided B<only>
237
for the use of scripts such as C<bulkmarcimport.pl> that may need
237
for the use of scripts such as C<bulkmarcimport.pl> that may need
238
to do some manipulation of the MARC record for item parsing before
238
to do some manipulation of the MARC record for item parsing before
239
saving it and which cannot afford the performance hit of saving
239
saving it and which cannot afford the performance hit of saving
(-)a/C4/Items.pm (-2 / +2 lines)
Lines 327-334 embedded item fields. This routine is suitable for batch jobs. Link Here
327
327
328
This API assumes that the bib record has already been
328
This API assumes that the bib record has already been
329
saved to the C<biblio> and C<biblioitems> tables.  It does
329
saved to the C<biblio> and C<biblioitems> tables.  It does
330
not expect that C<biblioitems.marc> and C<biblioitems.marcxml>
330
not expect that C<biblioitems.marcxml> are populated, but it
331
are populated, but it will do so via a call to ModBibiloMarc.
331
will do so via a call to ModBibiloMarc.
332
332
333
The goal of this API is to have a similar effect to using AddBiblio
333
The goal of this API is to have a similar effect to using AddBiblio
334
and AddItems in succession, but without inefficient repeated
334
and AddItems in succession, but without inefficient repeated
(-)a/C4/Overdues.pm (-3 / +1 lines)
Lines 159-165 Returns a count and a list of overdueitems for a given borrowernumber Link Here
159
159
160
sub checkoverdues {
160
sub checkoverdues {
161
    my $borrowernumber = shift or return;
161
    my $borrowernumber = shift or return;
162
    # don't select biblioitems.marc or biblioitems.marcxml... too slow on large systems
162
    # don't select biblioitems.marcxml... too slow on large systems
163
    my $sth = C4::Context->dbh->prepare(
163
    my $sth = C4::Context->dbh->prepare(
164
        "SELECT biblio.*, items.*, issues.*,
164
        "SELECT biblio.*, items.*, issues.*,
165
                biblioitems.volume,
165
                biblioitems.volume,
Lines 196-202 sub checkoverdues { Link Here
196
            WHERE issues.borrowernumber  = ?
196
            WHERE issues.borrowernumber  = ?
197
            AND   issues.date_due < NOW()"
197
            AND   issues.date_due < NOW()"
198
    );
198
    );
199
    # FIXME: SELECT * across 4 tables?  do we really need the marc AND marcxml blobs??
200
    $sth->execute($borrowernumber);
199
    $sth->execute($borrowernumber);
201
    my $results = $sth->fetchall_arrayref({});
200
    my $results = $sth->fetchall_arrayref({});
202
    return ( scalar(@$results), $results);  # returning the count and the results is silly
201
    return ( scalar(@$results), $results);  # returning the count and the results is silly
203
- 

Return to bug 10455