Bugzilla – Attachment 54850 Details for
Bug 10455
remove redundant 'biblioitems.marc' field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10455: (follow-up) Remove biblioitems.marc
Bug-10455-follow-up-Remove-biblioitemsmarc.patch (text/plain), 2.90 KB, created by
Jonathan Druart
on 2016-08-25 10:30:31 UTC
(
hide
)
Description:
Bug 10455: (follow-up) Remove biblioitems.marc
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-25 10:30:31 UTC
Size:
2.90 KB
patch
obsolete
>From ac15176df0369e66c2929203023c31d5fa743098 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 25 Aug 2016 11:26:45 +0100 >Subject: [PATCH] Bug 10455: (follow-up) Remove biblioitems.marc > >--- > C4/Biblio.pm | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 2f0093e..056beeb 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -3312,7 +3312,6 @@ sub _koha_add_biblioitem { > size = ?, > place = ?, > lccn = ?, >- marc = ?, > url = ?, > cn_source = ?, > cn_class = ?, >@@ -3330,7 +3329,7 @@ sub _koha_add_biblioitem { > $biblioitem->{'volumedate'}, $biblioitem->{'volumedesc'}, $biblioitem->{'collectiontitle'}, $biblioitem->{'collectionissn'}, > $biblioitem->{'collectionvolume'}, $biblioitem->{'editionstatement'}, $biblioitem->{'editionresponsibility'}, $biblioitem->{'illus'}, > $biblioitem->{'pages'}, $biblioitem->{'bnotes'}, $biblioitem->{'size'}, $biblioitem->{'place'}, >- $biblioitem->{'lccn'}, $biblioitem->{'marc'}, $biblioitem->{'url'}, $biblioitem->{'biblioitems.cn_source'}, >+ $biblioitem->{'lccn'}, $biblioitem->{'url'}, $biblioitem->{'biblioitems.cn_source'}, > $biblioitem->{'cn_class'}, $biblioitem->{'cn_item'}, $biblioitem->{'cn_suffix'}, $cn_sort, > $biblioitem->{'totalissues'}, $biblioitem->{'ean'}, $biblioitem->{'agerestriction'} > ); >@@ -3449,7 +3448,7 @@ sub _koha_delete_biblioitems { > > &ModBiblioMarc($newrec,$biblionumber,$frameworkcode); > >-Add MARC data for a biblio to koha >+Add MARC XML data for a biblio to koha > > Function exported, but should NOT be used, unless you really know what you're doing > >@@ -3457,7 +3456,7 @@ Function exported, but should NOT be used, unless you really know what you're do > > sub ModBiblioMarc { > # pass the MARC::Record to this function, and it will create the records in >- # the marc field >+ # the marcxml field > my ( $record, $biblionumber, $frameworkcode ) = @_; > if ( !$record ) { > carp 'ModBiblioMarc passed an undefined record'; >@@ -3504,8 +3503,8 @@ sub ModBiblioMarc { > $f005->update(sprintf("%4d%02d%02d%02d%02d%04.1f",@a)) if $f005; > } > >- $sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE biblionumber=?"); >- $sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding), $biblionumber ); >+ $sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE biblionumber=?"); >+ $sth->execute( $record->as_xml_record($encoding), $biblionumber ); > $sth->finish; > ModZebra( $biblionumber, "specialUpdate", "biblioserver", $record ); > return $biblionumber; >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10455
:
54844
|
54845
|
54846
|
54847
|
54849
|
54850
|
54855
|
54856
|
54857
|
54858
|
54859
|
54860
|
54875
|
54881
|
55401
|
55402
|
55403
|
55404
|
55405
|
55406
|
55407
|
55408
|
55409
|
55410
|
55844
|
55845
|
55846
|
55847
|
55848
|
55849
|
55850
|
55851
|
55852
|
55853