Bugzilla – Attachment 54879 Details for
Bug 15711
Deleting patroncard images has unexpected behaviour and is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15711: Fixing the 'Delete selected' button on patroncard images
SIGNED-OFF-Bug-15711-Fixing-the-Delete-selected-bu.patch (text/plain), 1.92 KB, created by
Owen Leonard
on 2016-08-25 15:07:13 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15711: Fixing the 'Delete selected' button on patroncard images
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-08-25 15:07:13 UTC
Size:
1.92 KB
patch
obsolete
>From be5e22efed677dca836a459a0ec9f9ee484e516a Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 24 Aug 2016 01:08:11 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 15711: Fixing the 'Delete selected' button > on patroncard images >Content-Type: text/plain; charset="utf-8" > >To test: >1) Go to Tools -> Patron Card Creator -> Manage images >2) Upload an image if you haven't already >3) Click Delete selected without selecting any images >4) Notice broken behaviour as described in Description >5) Apply patch, refresh page >6) Click Delete selected without selecting any images >7) Notice alert. Click OK >8) Select one image or more, click Delete selected >9) Notice confirm delete message. > >Sponsored-by: Catalyst IT > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >index 17387bd..0ce2007 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >@@ -5,7 +5,7 @@ > //<![CDATA[ > function DeleteConfirm() { > var results = selected_images("delete"); >- if (results.images != -1) { >+ if (results.images != 0) { > var msg = _("Are you sure you want to delete image(s): %s?").format(results.image_ids); > var answer = confirm(msg); > if (answer) { >@@ -14,6 +14,8 @@ > else { > return; // abort delete > } >+ } else { >+ alert(_("Please select images to delete.")); > } > }; > function selected_images(op) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15711
:
54801
|
54879
|
57877
|
57944
|
57945
|
58189
|
58190
|
58444
|
58445