From 4c72d9cbe4f0f812d65e410b25db5d17975ad5a2 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Wed, 31 Aug 2016 15:52:08 +0200 Subject: [PATCH] Bug 17229: Add unit test for BlockExpiredPatronOpacActions check --- t/db_dependent/Holds.t | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index f9ddc46..355e865 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -8,7 +8,7 @@ use t::lib::TestBuilder; use C4::Context; use C4::Branch; -use Test::More tests => 60; +use Test::More tests => 61; use MARC::Record; use C4::Biblio; use C4::Items; @@ -34,7 +34,12 @@ my $dbh = C4::Context->dbh; my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode }; my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode }; -my $category = $builder->build({ source => 'Category' }); +my $category = $builder->build({ + source => 'Category', + value => { + BlockExpiredPatronOpacActions => -1, + }, +}); my $borrowers_count = 5; @@ -473,6 +478,17 @@ my $res_id = AddReserve( $branch_1, $borrowernumbers[0], $bibnum, '', 1, ); is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ), 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' ); +my $expired_borrowernumber = AddMember( + firstname => 'Expired', + surname => 'Patron', + categorycode => $category->{categorycode}, + branchcode => $branch_1, + dateexpiry => '2000-01-01', +); +t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1); +is(CanItemBeReserved($expired_borrowernumber, $itemnumber), + 'expired', 'Expired patron cannot reserve'); + # Helper method to set up a Biblio. sub create_helper_biblio { -- 2.1.4