From bede3256b46171784a94cf14b303430209a388cd Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 31 Aug 2016 14:20:34 +0200 Subject: [PATCH] Bug 15758: [QA Follow-up] Final touch? Content-Type: text/plain; charset=utf-8 From qa tools: reports/cat_issues_top.pl: pod: =over on line 39 without closing =back Note: qa tools does also report "options_for_libraries: not found" on two template includes. Considering this as a false alarm, since the block is defined in another include loaded in doc-head-open. [1] koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc [2] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc Found a template where a USE Branches was missing: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Easy to spot since the libraries combo was empty. Tried to find similar occurrences with few greps, but couldn't find any. I did find duplicate USE Branches though in: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt This patch removes them. Signed-off-by: Marcel de Rooy --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 1 + reports/cat_issues_top.pl | 2 -- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index e0bdc5a..0006fca 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -3,7 +3,6 @@ Koha › Administration › Circulation and fine rules [% INCLUDE 'doc-head-close.inc' %] [% INCLUDE 'calendar.inc' %] -[% USE Branches %]