From d5d3fe685a7b35e9013b2a904dbc9ed2c05269eb Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 6 Sep 2016 10:40:46 +0100 Subject: [PATCH] Bug 14637: Fix add patron category under MySQL 5.7 If no dateofbirthrequired or upperagelimit is set on the interface, the ->store method will receive an empty string defined for these values. For INT field, we must explicitely set these empty value to undef instead to avoid MySQL 5.7 (and strict mode) to raise: DBD::mysql::st execute failed: Incorrect integer value: ' for column 'dateofbirthrequired'' Test plan: Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES) Create a patron category without specifying upperagelimit or dateofbirthrequired --- Koha/Patron/Category.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm index 06012ec..3f8ead6 100644 --- a/Koha/Patron/Category.pm +++ b/Koha/Patron/Category.pm @@ -37,6 +37,12 @@ Koha::Patron;;Category - Koha Patron;;Category Object class sub store { my ( $self ) = @_; + $self->dateofbirthrequired(undef) + if not defined $self->dateofbirthrequired + or $self->dateofbirthrequired eq ''; + $self->upperagelimit(undef) + if not defined $self->upperagelimit + or $self->upperagelimit eq ''; $self->checkprevcheckout('inherit') unless defined $self->checkprevcheckout; return $self->SUPER::store; -- 2.8.1