From 51f8db1f635bf7d70f7a12071d6e3e3993b3bbb8 Mon Sep 17 00:00:00 2001 From: Hector Castro Date: Wed, 31 Aug 2016 13:33:53 -0600 Subject: [PATCH] Bug 17152: (counter-patch)Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Nick Clemens --- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js index 87b65fe..6f55930 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js @@ -255,7 +255,6 @@ function CloneSubfield(index, advancedMARCEditor){ var original = document.getElementById(index); //original
var clone = original.cloneNode(true); var new_key = CreateKey(); - // set the attribute for the new 'div' subfields var inputs = clone.getElementsByTagName('input'); var selects = clone.getElementsByTagName('select'); @@ -270,6 +269,7 @@ function CloneSubfield(index, advancedMARCEditor){ inputs[i].setAttribute('name',inputs[i].getAttribute('name')+new_key); linkid = id_input; } + // Plugin input if( $(inputs[1]).hasClass('framework_plugin') ) { var oldcontrol= original.getElementsByTagName('input')[1]; @@ -326,6 +326,8 @@ function CloneSubfield(index, advancedMARCEditor){ } // insert this line on the page original.parentNode.insertBefore(clone,original.nextSibling); + // delete data of cloned subfield + document.getElementById(linkid).value = ""; } function AddEventHandlers (oldcontrol, newcontrol, newinputid ) { -- 2.1.4