View | Details | Raw Unified | Return to bug 5670
Collapse All | Expand All

(-)a/Koha/Patron/HouseboundVisit.pm (-2 / +5 lines)
Lines 18-23 package Koha::Patron::HouseboundVisit; Link Here
18
use Modern::Perl;
18
use Modern::Perl;
19
19
20
use Koha::Database;
20
use Koha::Database;
21
use Koha::Patron;
21
22
22
use base qw(Koha::Object);
23
use base qw(Koha::Object);
23
24
Lines 49-55 Returns the prefetched chooser for this visit. Link Here
49
50
50
sub chooser {
51
sub chooser {
51
    my ( $self ) = @_;
52
    my ( $self ) = @_;
52
    return $self->_result->chooser_brwnumber;
53
    my $rs = $self->_result->chooser_brwnumber;
54
    return Koha::Patron->_new_from_dbic( $rs );
53
}
55
}
54
56
55
=head3 deliverer
57
=head3 deliverer
Lines 62-68 Returns the prefetched deliverer for this visit. Link Here
62
64
63
sub deliverer {
65
sub deliverer {
64
    my ( $self ) = @_;
66
    my ( $self ) = @_;
65
    return $self->_result->deliverer_brwnumber;
67
    my $rs = $self->_result->deliverer_brwnumber;
68
    return Koha::Patron->_new_from_dbic( $rs );
66
69
67
}
70
}
68
71
(-)a/t/db_dependent/Patron/HouseboundVisits.t (-6 / +2 lines)
Lines 81-91 is( $result->deliverer->borrowernumber, $visit->{deliverer_brwnumber} ); Link Here
81
81
82
is( $result->chooser->borrowernumber, $visit->{chooser_brwnumber} );
82
is( $result->chooser->borrowernumber, $visit->{chooser_brwnumber} );
83
83
84
TODO: {
84
isa_ok( $result->deliverer, "Koha::Patron");
85
    local $TODO = "We want our results here to be Koha::Patron objects, but they by default return DBIC Schema objects.  The currently accepted solution to this (use the _from_dbic method), is defined for Koha::Objects, but not for Koha::Object.  We do not resolve this issue here";
85
isa_ok( $result->chooser, "Koha::Patron");
86
    isa_ok( $result->deliverer, "Koha::Patron");
87
    isa_ok( $result->chooser, "Koha::Patron");
88
}
89
86
90
$schema->storage->txn_rollback;
87
$schema->storage->txn_rollback;
91
88
92
- 

Return to bug 5670