From 04e79db3a564accf7a9171944fc14e0dc685a672 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Date: Wed, 31 Aug 2016 14:20:34 +0200 Subject: [PATCH] Bug 15758: [QA Follow-up] Final touch? From qa tools: reports/cat_issues_top.pl: pod: =over on line 39 without closing =back Note: qa tools does also report "options_for_libraries: not found" on two template includes. Considering this as a false alarm, since the block is defined in another include loaded in doc-head-open. [1] koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc [2] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc Found a template where a USE Branches was missing: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Easy to spot since the libraries combo was empty. Tried to find similar occurrences with few greps, but couldn't find any. I did find duplicate USE Branches though in: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt This patch removes them. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 1 + reports/cat_issues_top.pl | 2 -- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 5bee89e..4a941a7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -3,7 +3,6 @@ <title>Koha › Administration › Circulation and fine rules</title> [% INCLUDE 'doc-head-close.inc' %] [% INCLUDE 'calendar.inc' %] -[% USE Branches %] <script type="text/javascript"> //<![CDATA[ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt index 45e3704..a08e88f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt @@ -4,7 +4,6 @@ <title>Koha › Serials › Check expiration</title> [% INCLUDE 'doc-head-close.inc' %] [% INCLUDE 'calendar.inc' %] -[% USE Branches %] <script type="text/javascript" language="JavaScript"> // <![CDATA[ /** diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt index 948d8af..76aaabe 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt @@ -1,4 +1,5 @@ [% USE KohaDates %] +[% USE Branches %] [% INCLUDE 'doc-head-open.inc' %] <title>Koha › Serials › [% IF ( modify ) %][% bibliotitle |html %] › Modify subscription[% ELSE %]New subscription[% END %]</title> diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl index dd37811..08b1852 100755 --- a/reports/cat_issues_top.pl +++ b/reports/cat_issues_top.pl @@ -36,8 +36,6 @@ plugin that shows a stats on borrowers =head1 DESCRIPTION -=over 2 - =cut my $input = new CGI; -- 2.8.1