Bugzilla – Attachment 55743 Details for
Bug 17310
Broken URLs in 'Item renewed' / 'Cannot renew' messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages
SIGNED-OFFBug-17310-Broken-URLs-in-Item-renewed--C.patch (text/plain), 3.68 KB, created by
Héctor Eduardo Castro Avalos
on 2016-09-21 21:27:59 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-09-21 21:27:59 UTC
Size:
3.68 KB
patch
obsolete
>From e0dd8a56b72a127501c76961e557fa3e57842319 Mon Sep 17 00:00:00 2001 >From: Andreas Roussos <arouss1980@gmail.com> >Date: Sat, 17 Sep 2016 13:44:47 +0300 >Subject: [PATCH] [SIGNED-OFF]Bug 17310: Broken URLs in 'Item renewed' / > 'Cannot renew' messages > >In the Staff client, under Circulation > Renew, the message shown after >successful renewal of an item contains broken URLs. This is also true for >the message shown when you try to renew an item that is not checked out. > >This patch fixes that. > >Test plan: >1) Go to Circulation > Renew, and search for the barcode of a checked-out > item. In the 'Item renewed:' confirmation message, notice how the URLs > for the title and the barcode are broken. >2) Now search for the barcode of an item that is not checked out. In the > 'Cannot renew:' message, notice how the URLs are broken here too. >3) Apply the patch. >4) Repeat steps 1) and 2). This time the URLs work fine. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt >index 7c481f4..947767d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt >@@ -39,7 +39,7 @@ > > [% ELSIF error == "no_checkout" %] > >- <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblionumber %]">[% item.biblio.title %] [% item.biblioitem.subtitle %]</a> ( <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% item.itemnumber %]&biblionumber=[% item.biblionumber %]&bi=[% item.biblioitemnumber.biblioitemnumber %]#item[% item.itemnumber %]">[% item.barcode %]</a> ) is not checked out to a patron.</p> >+ <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblio.biblionumber %]">[% item.biblio.title %] [% item.biblioitem.subtitle %]</a> ( <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% item.itemnumber %]&biblionumber=[% item.biblio.biblionumber %]&bi=[% item.biblioitemnumber.biblioitemnumber %]#item[% item.itemnumber %]">[% item.barcode %]</a> ) is not checked out to a patron.</p> > > [% ELSIF error == "too_many" %] > >@@ -120,8 +120,8 @@ > <div class="dialog message"> > <h3>Item renewed:</h3> > <p> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblionumber %]">[% item.biblio.title %] [% item.biblioitem.subtitle %]</a> >- ( <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% item.itemnumber %]&biblionumber=[% item.biblionumber %]&bi=[% item.biblioitemnumber.biblioitemnumber %]#item[% item.itemnumber %]">[% item.barcode %]</a> ) >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% item.biblio.biblionumber %]">[% item.biblio.title %] [% item.biblioitem.subtitle %]</a> >+ ( <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% item.itemnumber %]&biblionumber=[% item.biblio.biblionumber %]&bi=[% item.biblioitemnumber.biblioitemnumber %]#item[% item.itemnumber %]">[% item.barcode %]</a> ) > renewed for > [% borrower.firstname %] [% borrower.surname %] ( <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrower.borrowernumber %]"> [% borrower.cardnumber %] </a> ) > now due on [% date_due | $KohaDates %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17310
:
55630
|
55743
|
55797